Add resize SDK API for storage pool #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-px
force-pushed
the
resize-pool-master
branch
2 times, most recently
from
48f874b
to
471a89b
Compare
adityadani
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
lgtm. There is an SDK version update required when a new change is added to proto. @lpabon
cmd/osd/main.go
Outdated
| @@ -477,16 +479,20 @@ func start(c *cli.Context) error { | |||
| return fmt.Errorf("Unable to Initialise Storage Policy Manager Instances %v", err) | |||
| } | |||
|
|
|||
| poolServer := mockapi.NewMockOpenStoragePoolServer(gomock.NewController( | |||
There was a problem hiding this comment.
This should not be mock but an actual server.
There was a problem hiding this comment.
removed this from osd main. nil server handler is now being handled.
lpabon
requested changes
Aug 27, 2019
api/api.proto
Outdated
| @@ -232,6 +232,8 @@ message StoragePool { | |||
| uint64 Used = 8; | |||
| // Labels is a list of user defined name-value pairs | |||
| map<string, string> labels = 9; | |||
| // UUID is the unique identifier for a storage pool | |||
| string UUID = 10; | |||
There was a problem hiding this comment.
value must be in proto style: uuid not UUID.
api/api.proto
Outdated
| } | ||
|
|
||
| // Defines the operation types available to resize a storage pool | ||
| enum StoragePoolResizeOperationType { |
There was a problem hiding this comment.
See #962 . These need to be redone
There was a problem hiding this comment.
I need to redo the doc/sdk.md to add this so others know about it.
There was a problem hiding this comment.
done. Moved newly added enums inside messages.
api/server/sdk/server.go
Outdated
| @@ -468,6 +473,7 @@ func (s *sdkGrpcServer) Start() error { | |||
| api.RegisterOpenStorageClusterPairServer(grpcServer, s.clusterPairServer) | |||
| api.RegisterOpenStoragePolicyServer(grpcServer, s.policyServer) | |||
| api.RegisterOpenStorageClusterDomainsServer(grpcServer, s.clusterDomainsServer) | |||
| api.RegisterOpenStoragePoolServer(grpcServer, s.storagePoolServer) | |||
There was a problem hiding this comment.
What happens if the storagepool server handler is nil?
There was a problem hiding this comment.
updated PR now handles nil pool server handler.
|
Also, |
harsh-px
force-pushed
the
resize-pool-master
branch
from
471a89b
to
8ea8c64
Compare
harsh-px
commented
Aug 29, 2019
api/api.proto
Outdated
| @@ -232,6 +232,8 @@ message StoragePool { | |||
| uint64 Used = 8; | |||
| // Labels is a list of user defined name-value pairs | |||
| map<string, string> labels = 9; | |||
| // UUID is the unique identifier for a storage pool | |||
| string UUID = 10; | |||
api/api.proto
Outdated
| } | ||
|
|
||
| // Defines the operation types available to resize a storage pool | ||
| enum StoragePoolResizeOperationType { |
There was a problem hiding this comment.
done. Moved newly added enums inside messages.
api/server/sdk/server.go
Outdated
| @@ -468,6 +473,7 @@ func (s *sdkGrpcServer) Start() error { | |||
| api.RegisterOpenStorageClusterPairServer(grpcServer, s.clusterPairServer) | |||
| api.RegisterOpenStoragePolicyServer(grpcServer, s.policyServer) | |||
| api.RegisterOpenStorageClusterDomainsServer(grpcServer, s.clusterDomainsServer) | |||
| api.RegisterOpenStoragePoolServer(grpcServer, s.storagePoolServer) | |||
There was a problem hiding this comment.
updated PR now handles nil pool server handler.
cmd/osd/main.go
Outdated
| @@ -477,16 +479,20 @@ func start(c *cli.Context) error { | |||
| return fmt.Errorf("Unable to Initialise Storage Policy Manager Instances %v", err) | |||
| } | |||
|
|
|||
| poolServer := mockapi.NewMockOpenStoragePoolServer(gomock.NewController( | |||
There was a problem hiding this comment.
removed this from osd main. nil server handler is now being handled.
lpabon
approved these changes
Aug 30, 2019
added 2 commits
September 26, 2019 12:29
Signed-off-by: Harsh Desai <[email protected]>
- bump SDK version - Fix enums and move them inside message in proto - handle nil SDK server - remove mock storage pool sdk server from osd main Signed-off-by: Harsh Desai <[email protected]>
harsh-px
force-pushed
the
resize-pool-master
branch
from
8ea8c64
to
ab6155d
Compare
Signed-off-by: Harsh Desai <[email protected]>
harsh-px
force-pushed
the
resize-pool-master
branch
from
ab6155d
to
0e9461e
Compare
harsh-px
pushed a commit
to harsh-px/openstorage
that referenced
this pull request
Sep 26, 2019
* Add resize SDK API for storage pool Signed-off-by: Harsh Desai <[email protected]> * Review comments - bump SDK version - Fix enums and move them inside message in proto - handle nil SDK server - remove mock storage pool sdk server from osd main Signed-off-by: Harsh Desai <[email protected]> * rebase with master Signed-off-by: Harsh Desai <[email protected]>
harsh-px
pushed a commit
that referenced
this pull request
Sep 26, 2019
…#1250) * Add resize SDK API for storage pool (#1200) * Add resize SDK API for storage pool Signed-off-by: Harsh Desai <[email protected]> * Review comments - bump SDK version - Fix enums and move them inside message in proto - handle nil SDK server - remove mock storage pool sdk server from osd main Signed-off-by: Harsh Desai <[email protected]> * rebase with master Signed-off-by: Harsh Desai <[email protected]> * fix compile Signed-off-by: Harsh Desai <[email protected]>
harsh-px
pushed a commit
to harsh-px/openstorage
that referenced
this pull request
Sep 27, 2019
…nstorage#1200) (libopenstorage#1250) * Add resize SDK API for storage pool (libopenstorage#1200) * Add resize SDK API for storage pool Signed-off-by: Harsh Desai <[email protected]> * Review comments - bump SDK version - Fix enums and move them inside message in proto - handle nil SDK server - remove mock storage pool sdk server from osd main Signed-off-by: Harsh Desai <[email protected]> * rebase with master Signed-off-by: Harsh Desai <[email protected]> * fix compile Signed-off-by: Harsh Desai <[email protected]>
harsh-px
pushed a commit
that referenced
this pull request
Sep 29, 2019
#1252) * [cherry-pick release-7.0 ]Add resize SDK API for storage pool (#1200) (#1250) * Add resize SDK API for storage pool (#1200) * Add resize SDK API for storage pool Signed-off-by: Harsh Desai <[email protected]> * Review comments - bump SDK version - Fix enums and move them inside message in proto - handle nil SDK server - remove mock storage pool sdk server from osd main Signed-off-by: Harsh Desai <[email protected]> * rebase with master Signed-off-by: Harsh Desai <[email protected]> * fix compile Signed-off-by: Harsh Desai <[email protected]> * fix sdk-version check Signed-off-by: Harsh Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Desai [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: