Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace SDK enums so that theirs strings are easier to read #962

Open
lpabon opened this issue Mar 20, 2019 · 0 comments
Open

Namespace SDK enums so that theirs strings are easier to read #962

lpabon opened this issue Mar 20, 2019 · 0 comments

Comments

@lpabon
Copy link
Member

lpabon commented Mar 20, 2019

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE

What happened:
SDK proto enums should be inside a message so that the strings are easier to comprehend. Instead of using:

openstorage/api/api.proto

Lines 2721 to 2724 in a0292eb

enum SdkCloudBackupStatusType {
// Unkonwn
SdkCloudBackupStatusTypeUnknown = 0;
// Not started

Use:

openstorage/api/api.proto

Lines 3129 to 3137 in a0292eb

message CloudMigrate {
enum OperationType {
InvalidType = 0;
// Migrate all volumes in the cluster
MigrateCluster = 1;
// Migrate a single volume
MigrateVolume = 2;
// Migrate a group of volumes
MigrateVolumeGroup = 3;

See: #957 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant