Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to compute channel grids for modular. #81

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

veluca93
Copy link
Member

@veluca93 veluca93 commented Jan 1, 2025

Also compute the relevant transforms "decomposed" to operate on grid chunks, and the dependencies in decoding (i.e. which inputs are needed for which transform).

jxl/src/frame/modular/transforms.rs Outdated Show resolved Hide resolved
Also compute the relevant transforms "decomposed" to operate on grid
chunks, and the dependencies in decoding (i.e. which inputs are needed
for which transform).
Copy link
Member

@jonsneyers jonsneyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be useful to create a set of test bitstreams (in addition to the conformance set), maybe using jxl_from_tree (though some extra stuff will need to be exposed such as delta palette predictor choice/nb_deltas, and progressive scans info), to test exotic combinations of modular transforms. The libjxl encoder doesn't produce weird combinations like delta palette plus squeeze...

@veluca93
Copy link
Member Author

veluca93 commented Jan 1, 2025

LGTM. It would be useful to create a set of test bitstreams (in addition to the conformance set), maybe using jxl_from_tree (though some extra stuff will need to be exposed such as delta palette predictor choice/nb_deltas, and progressive scans info), to test exotic combinations of modular transforms. The libjxl encoder doesn't produce weird combinations like delta palette plus squeeze...

Yup, we definitely should check that at some point or another...

@veluca93 veluca93 merged commit ddb0ba5 into libjxl:main Jan 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants