Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation #659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

schriftgestalt
Copy link
Contributor

No description provided.

);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /usr/bin/python;
shellScript = "# encoding=utf-8\n\nimport os, time, codecs\nroot = os.getenv('SRCROOT')\nprint \"update localisation in\", root\nfor (dirpath, dirnames, filenames) in os.walk(root):\n if \"en.lproj\" in dirnames:\n os.chdir(dirpath)\n os.system(\"find ./ -name '*.mm' -o -name '*.m' | xargs genstrings -u -q -o en.lproj\")\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split that into ./script/update-localization ? That would be ❤️, as that would save my soul from Xcode make it much easier to edit.

Copy link
Contributor

@tiennou tiennou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying to tackle this. I'm not in a position to benefit from it yet (GitX doesn't even have correct localization support), but it's always nice to have support for i18n.

A few points :

  • as I alluded to in small hack that the underlying problem is visible to the user then the error is displayed with [NSApp presentError:] #658, I think the first "mission" would be to fix our -[NSError git_errorWithCode:description:…] method, because it's not amenable to correct error messages. So either it should be removed in favor of -git_errorWithCode:description:failureReason:… (which forces a revisit of all localizable strings), or it should be renamed to -git_errorWithCode:failureReason:…, with a generic @"An error occurred" description (though the failure reason would still read strangely IMHO).
  • I'd like to have the localization comments be helpful. My current comment pattern in GitX looks like this, so something like @"classname - description of what it's used for". If we want to tackle localization, I'd prefer to have a good set of "rules" before moving on.

PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Profile;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hunk should be left out — that's codesigning configuration.

CreatedOnToolsVersion = 9.4.1;
DevelopmentTeam = X2L8375ZQ7;
ProvisioningStyle = Automatic;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted codesigning hunk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed that. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants