Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libgit2 to v1.1.1 #114

Merged
merged 5 commits into from
Aug 21, 2021

Conversation

jairbubbles
Copy link
Contributor

@jairbubbles jairbubbles commented May 10, 2021

I'm trying to update libgit2 to a more recent version to get support for the sparse checkout (see libgit2/libgit2sharp#1845)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some changes in the API in the recent versions of libgit2, so some more work is required. Please have a look at: mendix/libgit2sharp@f958478

We've forked the project to incorporate some changes we need. Unfortunately, we could not get much attention for our pull requests in this repository, and we kept accidentally creating new pull requests to this upstream repo, so we had to disconnect our fork from it.

@jairbubbles
Copy link
Contributor Author

Thanks for the info @A-Ovchinnikov-mx ! It's too bad we can't all work on the upstream repository 😭

@ethomson
Copy link
Member

ethomson commented Jun 17, 2021

You can. LibGit2Sharp needs a maintainer. Maybe that person is you!? libgit2/libgit2sharp#1834

@ghost
Copy link

ghost commented Jun 17, 2021

I would love to help but I'm a bit afraid I won't be able to dedicate too much time to it 😬 And that would be my personal investment, not from the company. If that's already good enough, then I can drop a message in that thread from my personal GitHub account.

@jairbubbles jairbubbles marked this pull request as draft August 16, 2021 09:20
@jairbubbles
Copy link
Contributor Author

jairbubbles commented Aug 16, 2021

Hello @bording, I saw you did some modification recently and I was wondering what do you think of moving forward with the libgit version? A new version 1.1.1 was also published that we could target.

I looked at @A-Ovchinnikov-mx commits but the fixes need to be done on libgit2sharp side. (It's linked to libgit2/libgit2#5117)

@jairbubbles jairbubbles changed the title Update libgit2 to v1.1.0 Update libgit2 to v1.1.1 Aug 16, 2021
@bording
Copy link
Member

bording commented Aug 16, 2021

Hello @bording, I saw you did some modification recently and I was wondering what do you think of moving forward with the libgit version? A new version 1.1.1 was also published that we could target.

My plan is to move up to a newer version of libgit2, but I was hoping to wait for libgit2/libgit2#5974 land first.

build.libgit2.ps1 Outdated Show resolved Hide resolved
@jairbubbles
Copy link
Contributor Author

I'm not particularly in a hurry so that's fine with me to wait for a newer version. In the meantime, would it be possible to publish an alpha version of the native binaries NuGet packages so that I can create a draft PR on libgit2sharp repo to make sure the CI is all green?

@jairbubbles jairbubbles marked this pull request as ready for review August 17, 2021 09:54
@bording bording merged commit 84713e3 into libgit2:master Aug 21, 2021
@jairbubbles jairbubbles deleted the update-libgit2-to-v1-1-0 branch September 3, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants