Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add send constraint for Link #549

Closed
wants to merge 2 commits into from
Closed

Add send constraint for Link #549

wants to merge 2 commits into from

Conversation

taikulawo
Copy link
Contributor

@taikulawo taikulawo commented Aug 9, 2023 •
edited
Loading

fix #546

@taikulawo
Copy link
Contributor Author

taikulawo commented Aug 9, 2023 •
edited
Loading

I decide to close this PR as there are many struct need Send such as OpenProgram, Link, OpenMap, I'm not sure whether those data structure are thread-safe, we would better re-investigate it

@taikulawo taikulawo closed this Aug 9, 2023
@danielocfb
Copy link
Collaborator

I decide to close this PR as there are many struct need Send such as OpenProgram, Link, OpenMap, I'm not sure whether those data structure are thread-safe, we would better re-investigate it

Yeah, we should take it one step at a time. Link should be safe to Send as per my understanding. There has been a bunch of discussions around similar or related issues here (and somewhere else I can't find off hand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we make libbpf_rs::Link impl Send trait?
2 participants
@taikulawo @danielocfb