Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize reusable workflows #147

Closed
wants to merge 1 commit into from

Conversation

theihor
Copy link
Contributor

@theihor theihor commented Oct 17, 2024

We want to maintain only one copy of each reusable workflow between libbpf/ci and kernel-patches/vmtests 1. To achieve that, libbpf/ci is going to be the source of truth for them, and kernel-patches/vmtest main workflow will be calling libbpf/ci.

This change reorganizes files to make it clear which workflows are reusable, and which are repository-specific. I suggest the following convention:

  • .github contains workflows local to the owner repository
  • workflows contains reusable workflows, intened for external use

We want to maintain only one copy of each reusable workflow between
libbpf/ci and kernel-patches/vmtests [1]. To achieve that, libbpf/ci
is going to be the source of truth for them, and kernel-patches/vmtest
main workflow will be calling libbpf/ci.

This change reorganizes files to make it clear which workflows are
reusable, and which are repository-specific. I suggest the following
convention:

* `.github` contains workflows local to the owner repository
* `workflows` contains reusable workflows, intened for external use

[1]: https://github.com/kernel-patches/vmtest/tree/master/.github
@theihor
Copy link
Contributor Author

theihor commented Oct 17, 2024

As it turns out, we can't do that because reasons. Not only can't we move to repo root, we also can't use a subdirectory in .github/workflows.

Reusable workflows are YAML-formatted files, very similar to any other workflow file. As with other workflow files, you locate reusable workflows in the .github/workflows directory of a repository. Subdirectories of the workflows directory are not supported.

@theihor theihor closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant