ansible: mask systemd-binfmt service on qemu-user-static install #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chantra
approved these changes
Oct 12, 2024
|
Also adding more details to the patch/PR description will help a potential future person to understand why the decision was made to mask that service. |
systemd-binfmt service [1], provided by systemd Ubuntu package [2] is in conflict with our custom one-shot qemu-user-static service. Recently an automated update of python3.12 on s390x BPF CI hosts triggered a restart of systemd-binfmt, which broke the test runners. Masking systemd-binfmt service shoud prevent similar runner failures in the future. Ideally we'd want to switch to systemd-binfmt. However currently it doesn't work for us: on s390x qemu segfaults with standard qemu-user-static binaries, as opposed to qus [3] container we're currently using. [1]: https://www.freedesktop.org/software/systemd/man/latest/systemd-binfmt.service.html [2]: https://manpages.ubuntu.com/manpages/noble/man8/systemd-binfmt.service.8.html [3]: https://github.com/dbhi/qus
theihor
force-pushed
the
mask-systemd-binfmt
branch
from
b81b7a6
to
f92c034
Compare
Updated commit message. Please let me know if I missed anything important. |
|
LGTM. Feel free to land whenever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.