Add end-to-end test for #875 #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an end-to-end test for the fix provided by pull request libbpf#875. The test basically normalizes an address in a specially crafted binary and symbolizes the resulting file offset. It fails without commit 1a4e107 ("Use file size in file offset -> virtual offset translation"), because then the file offset to virtual offset translation produces a virtual offset that can't be symbolized to the expected _start function. For the record, the binary looks roughly as follows: $ readelf --segments --wide test-block.bin > Program Headers: > Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align > LOAD 0x000000 0x00000000000ff000 0x00000000000ff000 0x0001c8 0x301000 RW 0x1000 > LOAD 0x0001c8 0x00000000004001c8 0x00000000004001c8 0x000030 0x000030 R 0x1000 > LOAD 0x001000 0x0000000000401000 0x0000000000401000 0x00005b 0x00005b R E 0x1000 > LOAD 0x002000 0x0000000000402000 0x0000000000402000 0x000038 0x000038 R 0x1000 > [...] Signed-off-by: Daniel Müller <[email protected]>
danielocfb
force-pushed
the
topic/file-size-e2e
branch
4 times, most recently
from
ab0e157
to
ecde9ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage ? 95.39%
=======================================
Files ? 55
Lines ? 10523
Branches ? 0
=======================================
Hits ? 10038
Misses ? 485
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an end-to-end test for the fix provided by pull request #875. The test basically normalizes an address in a specially crafted binary and symbolizes the resulting file offset. It fails without commit 1a4e107 ("Use file size in file offset -> virtual offset translation"), because then the file offset to virtual offset translation produces a virtual offset that can't be symbolized to the expected _start function.