-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Change position of info icon to error display for mobile view #619
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 114a688 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@sasamuku Am I correct in my understanding that the title and text should be aligned at the start on PC, but not on SP? You are right, it is complicated. |
Oh, my bad. 🙇♂️ It probably started around #446 or #502, but I just noticed it after seeing this comment. In browsers other than Chrome (e.g., Safari), the title message appears to be using a serif font-family.
I believe using a non-serif font is correct. Could you confirm? 🙏 @sasamuku |
Right, I considered changing a component structure, but it was difficult.
Sounds nice👍 I'll check with designer. |
Thanks for letting me know! I'll check it. Fixed by: |
Finally
@MH4GF Could you please re-review? |
Summary
Changed position of InfoIcon on ErrorDisplay.
The placement of the InfoIcon has been implemented in a tricky way.
Please let me know if there is a better way to meet design.
Before
After
Related Issue
Changes
Testing
Other Information