Enhance postgres parser test #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunamaYukina
commented
Nov 28, 2024
| @@ -5,7 +5,52 @@ exports[`parse > should parse postgresql to JSON correctly 1`] = ` | |||
| "relationships": {}, | |||
| "tables": { | |||
| "users": { | |||
| "columns": {}, | |||
There was a problem hiding this comment.
There was a mistake in resolving the conflict in PR #90, so I fixed it🙏.
FunamaYukina
requested review from
hoshinotsuyoshi,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
MH4GF
approved these changes
Nov 28, 2024
frontend/packages/db-structure/src/parser/sql/postgresql/converter.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Hirotaka Miyagi <[email protected]>
|
Thanks for reviewing this PR! |
| typeof node.String === 'object' && | ||
| node.String !== null && | ||
| 'str' in node.String && | ||
| node.String.str !== 'pg_catalog' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In PR #93, tests for schemarb's parse process were added. In this PR, I've added tests for PostgreSQL.
Related Issue
Changes
c551919 : add test for Postgresql parser
b9e95ed: fix parsing process (ex. type)
Testing
Other Information