feat: use notFound()

liam-hq · Oct 7, 2024 · b18a23f · b18a23f
1 parent bc13031
commit b18a23f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/frontend/apps/service-site/src/app/[lang]/posts/[slug]/page.tsx b/frontend/apps/service-site/src/app/[lang]/posts/[slug]/page.tsx
@@ -3,6 +3,7 @@ import { langSchema, langs } from '@/i18n'
 import { findPostByLangAndSlug } from '@/utils/posts'
 import { allPosts } from 'contentlayer/generated'
 import { format, parseISO } from 'date-fns'
+import { notFound } from 'next/navigation'
 import { object, parse, string } from 'valibot'
 
 export const generateStaticParams = async () => {
@@ -15,7 +16,7 @@ export const generateMetadata = ({ params }: PageProps) => {
   const { lang, slug } = parse(paramsSchema, params)
   const post = findPostByLangAndSlug({ lang, slug })
 
-  if (!post) throw new Error(`Post not found for slug: ${slug}`)
+  if (!post) notFound()
 
   return { title: post.title }
 }
@@ -29,7 +30,7 @@ export default function Page({ params }: PageProps) {
   const { lang, slug } = parse(paramsSchema, params)
 
   const post = findPostByLangAndSlug({ lang, slug })
-  if (!post) throw new Error(`Post not found for slug: ${slug}`)
+  if (!post) notFound()
 
   return (
     <article>

diff --git a/frontend/apps/service-site/src/app/posts/[slug]/page.tsx b/frontend/apps/service-site/src/app/posts/[slug]/page.tsx
@@ -3,6 +3,7 @@ import { fallbackLang } from '@/i18n'
 import { findPostByLangAndSlug } from '@/utils/posts'
 import { allPosts } from 'contentlayer/generated'
 import { format, parseISO } from 'date-fns'
+import { notFound } from 'next/navigation'
 import { object, parse, string } from 'valibot'
 
 export const generateStaticParams = async () =>
@@ -12,7 +13,7 @@ export const generateMetadata = ({ params }: PageProps) => {
   const { slug } = parse(paramsSchema, params)
   const post = findPostByLangAndSlug({ lang: fallbackLang, slug })
 
-  if (!post) throw new Error(`Post not found for slug: ${slug}`)
+  if (!post) notFound()
 
   return { title: post.title }
 }
@@ -25,7 +26,7 @@ export default function Page({ params }: PageProps) {
   const { slug } = parse(paramsSchema, params)
 
   const post = findPostByLangAndSlug({ lang: fallbackLang, slug })
-  if (!post) throw new Error(`Post not found for slug: ${slug}`)
+  if (!post) notFound()
 
   return (
     <article>