Fix sanitization of keywords (arrow-kt#3016)

lgtout · Mar 31, 2023 · 4dfdd62 · 4dfdd62
1 parent 0de655c
commit 4dfdd62
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/...ibs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/utils.kt b/...ibs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/utils.kt
@@ -12,8 +12,8 @@ fun String.plusIfNotBlank(prefix: String = "", postfix: String = "") =
 /**
  * Sanitizes each delimited section if it matches with Kotlin reserved keywords.
  */
-fun KSName.asSanitizedString(delimiter: String = ".", separator: String = delimiter) =
-  asString().splitToSequence(delimiter).joinToString(separator) { if (kotlinKeywords.contains(it)) "`$it`" else it }
+fun KSName.asSanitizedString(delimiter: String = ".") =
+  asString().splitToSequence(delimiter).joinToString(delimiter) { if (it in kotlinKeywords) "`$it`" else it }
 
 
 private val kotlinKeywords = setOf(

diff --git a/arrow-libs/optics/arrow-optics-ksp-plugin/src/test/kotlin/arrow/optics/plugin/DSLTests.kt b/arrow-libs/optics/arrow-optics-ksp-plugin/src/test/kotlin/arrow/optics/plugin/DSLTests.kt
@@ -61,5 +61,20 @@ class DSLTests {
       """.compilationSucceeds()
   }
 
+  @Test
+  fun `DSL for a class in a package including keywords, issue #2996`() {
+    """
+      |package id.co.app_name.features.main.transaction.internal.outgoing.data.OutgoingInternalTransaction
+      |
+      |$imports
+      |
+      |@optics
+      |data class Source(val program: String) {
+      |  companion object
+      |}
+      |
+      """.compilationSucceeds()
+  }
+
   // Db.content.at(At.map(), One).set(db, None)
 }