Chore: Add naming conventions to documentation #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModeSevenIndustrialSolutions
force-pushed
the
update-docs
branch
6 times, most recently
from
c4d9fbe
to
442a7b4
Compare
tykeal
reviewed
Oct 23, 2024
README.md
Outdated
| | --------------- | ---------------- | ---------------------- | | ||
| | [GV] | Gerrit (Verify) | gerrit-verify.yaml | | ||
| | [GM] | Gerrit (Merge) | gerrit-merge.yaml | | ||
| | [G] | Gerrit (Generic) | [either of the above] | |
There was a problem hiding this comment.
The Generic really should be listing a filename that is gerrit-<something>.yaml as we do technically actually support other types, just nobody is doing so in practice right now. To be specific this would be used for custom magic comment keyword triggers.
tykeal
reviewed
Oct 23, 2024
ModeSevenIndustrialSolutions
force-pushed
the
update-docs
branch
2 times, most recently
from
fd45176
to
ebe5a54
Compare
ModeSevenIndustrialSolutions
force-pushed
the
update-docs
branch
3 times, most recently
from
831ccff
to
f0b51c1
Compare
Signed-off-by: Matthew Watkins <[email protected]>
ModeSevenIndustrialSolutions
force-pushed
the
update-docs
branch
from
f0b51c1
to
49f65d3
Compare
tykeal
requested changes
Nov 1, 2024
| | Description | Directory Suffix | | ||
| | ----------- | ---------------- | | ||
| | Composite | -action | | ||
| | Javascript | -javascript | |
There was a problem hiding this comment.
To be specific this should be Typescript, not Javascript (related, but not exactly the same)
|
|
||
| Discussion Points (on the table above) | ||
|
|
||
| We could locate deployed workflows in a separate folder structure from |
There was a problem hiding this comment.
IIRC workflows must live under the workflows directory even if they're called by another workflow. If I'm not correct, can you point me to documentation or working example of being able to call them from someplace else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will pass linting if/when we merge: #188