Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace codespell with typos #7265

Merged
merged 12 commits into from
Jan 18, 2024
Merged

Replace codespell with typos #7265

merged 12 commits into from
Jan 18, 2024

Conversation

pgporada
Copy link
Member

@szepeviktor did much work to allow us to use rust tools in our containers. This is a continuation of that work that functions on x86_64 and Apple Silicon (aarch64) systems. The typos project includes the codespell dictionary amongst others.

@pgporada pgporada requested a review from a team as a code owner January 17, 2024 21:32
@pgporada pgporada requested a review from aarongable January 17, 2024 21:32
@pgporada
Copy link
Member Author

pgporada commented Jan 17, 2024

This build will not test successfully until we push a new container to Dockerhub containing the typos binary.

@aarongable
Copy link
Contributor

aarongable commented Jan 17, 2024

I know @pgporada and @beautifulentropy have already tested this locally; I'm doing the same right now. If it goes swimmingly, I'll push an updated image and rerun the tests here.

edit: Huzzah, it works!

@aarongable aarongable requested a review from a team January 17, 2024 23:56
@aarongable aarongable merged commit eb69e9a into main Jan 18, 2024
18 checks passed
@aarongable aarongable deleted the phil-rust-deps branch January 18, 2024 02:08
@pgporada
Copy link
Member Author

Thanks again @szepeviktor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants