Fix constructor for Version class (#521)

* add default values to properties not sent * release date is nullable * name cannot be nullable * adjust constructor of version so name can only be a string * require a minimum of latest version of json mapper to support class-string syntax --------- Co-authored-by: martin.reinfandt <[email protected]>
lesstif · Sep 26, 2023 · 1306db5 · 1306db5
1 parent 25f83be
commit 1306db5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/composer.json b/composer.json
@@ -7,7 +7,7 @@
         "php": "^8.0",
         "ext-curl": "*",
         "ext-json": "*",
-        "netresearch/jsonmapper": "^3.0|^4.0|^5.0",
+        "netresearch/jsonmapper": "^4.2",
         "monolog/monolog": "^2.0|^3.0"
     },
     "suggest": {

diff --git a/src/Issue/Version.php b/src/Issue/Version.php
@@ -31,7 +31,7 @@ class Version implements \JsonSerializable
     public ?string $startDate = null;
     public ?string $userStartDate = null;
 
-    public function __construct($name = null)
+    public function __construct(string $name)
     {
         $this->name = $name;
     }

diff --git a/src/Version/VersionService.php b/src/Version/VersionService.php
@@ -35,7 +35,7 @@ public function create($version)
 
         return $this->json_mapper->map(
             json_decode($ret),
-            new Version()
+            Version::class
         );
     }
 
@@ -71,7 +71,7 @@ public function get(string $id)
 
         return $this->json_mapper->map(
             json_decode($ret),
-            new Version()
+            Version::class
         );
     }
 
@@ -100,7 +100,7 @@ public function update(Version $version): Version
 
         return $this->json_mapper->map(
             json_decode($ret),
-            new Version()
+            Version::class
         );
     }