Call form execute hook after object update

lepidus · Sep 3, 2024 · 606d7ea · 606d7ea
1 parent a45c2fa
commit 606d7ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/controllers/grid/catalogEntry/form/PublicationFormatForm.inc.php b/controllers/grid/catalogEntry/form/PublicationFormatForm.inc.php
@@ -155,8 +155,6 @@ function readInputData() {
 	 * @see Form::execute()
 	 */
 	function execute(...$functionParams) {
-		parent::execute(...$functionParams);
-
 		$publicationFormatDao = DAORegistry::getDAO('PublicationFormatDAO'); /* @var $publicationFormatDao PublicationFormatDAO */
 		$publicationFormat = $this->getPublicationFormat();
 		if (!$publicationFormat) {
@@ -188,6 +186,8 @@ function execute(...$functionParams) {
 			SubmissionLog::logEvent(Application::get()->getRequest(), $this->getMonograph(), SUBMISSION_LOG_PUBLICATION_FORMAT_CREATE, 'submission.event.publicationFormatCreated', array('formatName' => $publicationFormat->getLocalizedName()));
 		}
 
+		parent::execute(...$functionParams);
+
 		$publication = Services::get('publication')->edit($publication, [], Application::get()->getRequest());
 
 		return $representationId;

diff --git a/controllers/grid/users/chapter/form/ChapterForm.inc.php b/controllers/grid/users/chapter/form/ChapterForm.inc.php
@@ -198,8 +198,6 @@ function readInputData() {
 	 * @see Form::execute()
 	 */
 	function execute(...$functionParams) {
-		parent::execute(...$functionParams);
-
 		$chapterDao = DAORegistry::getDAO('ChapterDAO'); /* @var $chapterDao ChapterDAO */
 		$chapter = $this->getChapter();
 		$isEdit = !!$chapter;
@@ -238,6 +236,8 @@ function execute(...$functionParams) {
 			DAORegistry::getDAO('SubmissionFileDAO')->updateChapterFiles($selectedFiles, $this->getChapter()->getId());
 		}
 
+		parent::execute(...$functionParams);
+
 		$publication = Services::get('publication')->edit($publication, [], Application::get()->getRequest());
 
 		return true;