Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware.launch.xml): read params from individual_params #6

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

mebasoglu
Copy link

Description

Transform values of sensors are located in both sensor_kit_launch and individual_params repos. Autoware reads these transform values from individual_params. However, it was commented out on autoware.launch.xml and the Autoware in our vehicle read params from sensor_kit_launch.

This PR uncomments the necessary config to make Autoware read params from individual_params.

Tests performed

Tested on the Golf vehicle.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@LeoDriveProject LeoDriveProject marked this pull request as ready for review September 8, 2023 15:31
Copy link

@ismetatabay ismetatabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ismetatabay ismetatabay merged commit 288633c into golf Sep 8, 2023
LeoDriveProject pushed a commit that referenced this pull request Sep 12, 2023
fix(autoware.launch.xml): read params from individual_params
@senagolcuk senagolcuk deleted the memin/dev/fix-individual-params branch February 13, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants