Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test - Sensors #5

Merged
merged 7 commits into from
May 14, 2020
Merged

Test - Sensors #5

merged 7 commits into from
May 14, 2020

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli YannLocatelli changed the title Initial commit Relevant sensors & comparison May 7, 2020
BSP of Disco-769 added and mbed libs associated to ST components. Some
files come from other libs present inside sensors libs. They will not be
included in deploy.
Temperature, Motion and Magnetometer sensors are initialized in
"board.*" files. A function "check_id()" turns on the LED1 if and ID of
a drivers is incorrect.
@YannLocatelli YannLocatelli linked an issue May 8, 2020 that may be closed by this pull request
@ladislas
Copy link
Member

ladislas commented May 8, 2020

Whaou merci @YannLocatelli ! :)

Est-ce qu'il est possible d'enlever tout le BSP de ST et de remettre que ce dont on a besoin ?

Je vois qu'il y a beaucoup de fichier dont on a pas vraiment besoin, genre audio.h.

Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

première review en plus des mes commentaires précédents sur l'intégralité du BSP

LKExp-mbed-sensors/src/main.cpp Outdated Show resolved Hide resolved
LKExp-mbed-sensors/src/main.cpp Outdated Show resolved Hide resolved
LKExp-mbed-sensors/src/board.cpp Outdated Show resolved Hide resolved
@YannLocatelli
Copy link
Member Author

YannLocatelli commented May 11, 2020

Est-ce qu'il est possible d'enlever tout le BSP de ST et de remettre que ce dont on a besoin ?
Ladislas, #5 (comment)

A été réalisé dans le commit 5d3694f

Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci Yann! Sans le BSP c'est beaucoup plus clair! C'est intéressant parce qu'on voit qu'ils ont fait un peu comme on voulait faire (et dont on parlait hier), ils ont plusieurs couches:

  • driver de bas niveau, par exemple dsox_reg
  • une interface par exemple, MagneticSensor
  • la capteur final qui implemente l'interface en utilisant les drivers, par exemple LSM303AGRMagSensor.h

@ladislas ladislas changed the title Relevant sensors & comparison Test - Sensors May 14, 2020
@ladislas ladislas merged commit 4a991fe into master May 14, 2020
@ladislas ladislas deleted the yann-mbed-sensors branch May 14, 2020 17:39
ladislas pushed a commit that referenced this pull request May 15, 2020
Test all sensors on the board.
ladislas pushed a commit that referenced this pull request May 15, 2020
Test all sensors on the board.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensors - Tests & Drivers
2 participants