hugo/feature/Add Stabilization to MotionKit #1315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPezz
changed the base branch from
develop
to
hugo/feature/Update-MotionKit-Rotation-to-Fusion
HPezz
force-pushed
the
hugo/feature/Add-Stabilization-to-MotionKit
branch
from
865de96 to
2e8dd9e
Compare
HPezz
force-pushed
the
hugo/feature/Update-MotionKit-Rotation-to-Fusion
branch
from
3088d4a to
9bd7ea9
Compare
🔖 Version comparison
|
📈 Changes Impact Analysis Report📌 Info
🤖 Firmware impact analysis
Click to show memory sections🔬 Detailed impact analysisClick to show detailed analysis for all targets
🗺️ Map files diff output
|
📈 Changes Impact Analysis Report📌 Info
🤖 Firmware impact analysis
Click to show memory sections🔬 Detailed impact analysisClick to show detailed analysis for all targets
🗺️ Map files diff output
|
Codecov Report
@@ Coverage Diff @@
## hugo/feature/Update-MotionKit-Rotation-to-Fusion #1315 +/- ##
====================================================================================
+ Coverage 98.73% 98.75% +0.01%
====================================================================================
Files 145 147 +2
Lines 3728 3765 +37
====================================================================================
+ Hits 3681 3718 +37
Misses 47 47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HPezz
force-pushed
the
hugo/feature/Update-MotionKit-Rotation-to-Fusion
branch
from
9bd7ea9 to
f60a856
Compare
HPezz
force-pushed
the
hugo/feature/Add-Stabilization-to-MotionKit
branch
from
2e8dd9e to
8784637
Compare
2 tasks
YannLocatelli
approved these changes
Mar 6, 2023
| _euler_angles_target = starting_angle; | ||
| } | ||
|
|
||
| auto StabilizationControl::processStabilizationAngle(EulerAngles current_angles) -> std::tuple<float, Rotation> |
There was a problem hiding this comment.
I wonder if this control really needs a PID to achieve its purpose, but it's ok as is.
| mock_imukit.call_angles_ready_callback(angles_quarter_left); | ||
| } | ||
|
|
||
| TEST_F(MotionKitTest, startStabilizationAndStop) |
There was a problem hiding this comment.
Consider to add the test with TimeOutOver
There was a problem hiding this comment.
Timeout is not yet implemented for stabilization but if is needed, a test will be add in consequence.
HPezz
force-pushed
the
hugo/feature/Update-MotionKit-Rotation-to-Fusion
branch
from
f60a856 to
ead1e0d
Compare
HPezz
force-pushed
the
hugo/feature/Update-MotionKit-Rotation-to-Fusion
branch
from
ead1e0d to
9f9fa0c
Compare
HPezz
force-pushed
the
hugo/feature/Add-Stabilization-to-MotionKit
branch
from
8784637 to
4aa661a
Compare
|
SonarCloud Quality Gate failed. |
HPezz
force-pushed
the
hugo/feature/Update-MotionKit-Rotation-to-Fusion
branch
from
b3f6b91 to
4cf6ce9
Compare
Base automatically changed from
hugo/feature/Update-MotionKit-Rotation-to-Fusion
to
develop
March 9, 2023 11:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a yaw stabilization method in MotionKit