Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 (update): Update from FileExchange state #1132

Merged
merged 5 commits into from
Nov 25, 2022
Merged

🚸 (update): Update from FileExchange state #1132

merged 5 commits into from
Nov 25, 2022

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Nov 17, 2022 •
edited
Loading

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Nov 17, 2022
@YannLocatelli YannLocatelli added this to the Future Release milestone Nov 17, 2022
@YannLocatelli YannLocatelli self-assigned this Nov 17, 2022
@YannLocatelli YannLocatelli mentioned this pull request Nov 17, 2022
Closed
@YannLocatelli YannLocatelli force-pushed the yann/feature/sm/update-state-from-file-exchange-state branch from 7f1c11e to a375023 Compare November 17, 2022 19:12
@YannLocatelli YannLocatelli force-pushed the yann/feature/rc-add-filexchange-state-and-actions branch from a45fe96 to c371bc2 Compare November 17, 2022 19:13
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #1132 (64b68f0) into yann/feature/rc-add-filexchange-state-and-actions (91fabb3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                                Coverage Diff                                 @@
##           yann/feature/rc-add-filexchange-state-and-actions    #1132   +/-   ##
==================================================================================
  Coverage                                              95.96%   95.96%           
==================================================================================
  Files                                                    138      138           
  Lines                                                   3297     3298    +1     
==================================================================================
+ Hits                                                    3164     3165    +1     
  Misses                                                   133      133
Impacted Files Coverage Δ
libs/RobotKit/include/StateMachine.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YannLocatelli YannLocatelli reopened this Nov 17, 2022
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169508 (64%) 92636 (35%) 30920 (5%)
os 420328 (26%) 1144344 (73%) 80688 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 419832 (20%)
420328 (20%)		 📈
496 (0%)		 80688 (15%) ø
bootloader ✔️ ✅ ✅ 169508 (8%) ø 30920 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 394076 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ ✅ ✅ 377068 (17%) ø 20432 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 352696 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 354216 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 374536 (17%) ø 20696 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 359232 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 360400 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189944 (9%) ø 48136 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 228960 (10%) ø 28320 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144696 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192776 (9%) ø 50960 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174872 (8%) ø 47904 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 162492 (7%) ø 46632 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63288 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78884 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114308 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 126092 (6%) ø 15296 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 80060 (3%) ø 13272 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-11-25 11:54:59.665813207 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-11-25 11:55:00.029816938 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       620(+620) |     18(+18) |     227(+227) |
+| [fill]                     |       648(+648) |     18(+18) |     227(+227) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       638(+638) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1544(+1544) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       596(+596) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       938(+938) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 173224(+173224) |   773(+773) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   70818(+70818) |   548(+548) | 25187(+25187) |
-| Subtotals                  | 377060(+377060) | 3944(+3944) | 76376(+76376) |
+| main.cpp.obj               |   71174(+71174) |   548(+548) | 25187(+25187) |
+| Subtotals                  | 377444(+377444) | 3944(+3944) | 76376(+76376) |
 Total Static RAM memory (data + bss): 80320(+80320) bytes
-Total Flash memory (text + data): 381004(+381004) bytes
+Total Flash memory (text + data): 381388(+381388) bytes
 
Flash used: 420328&nbsp;(20%) / total: 2097152
SRAM used: 80688&nbsp;(15%) / total: 524288

@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182028 (69%) 80116 (30%) 41616 (7%)
os 471604 (30%) 1093068 (69%) 91904 (17%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 470932 (22%)
471604 (22%)		 📈
672 (0%)		 91904 (17%) ø
bootloader ✔️ ✅ ✅ 182028 (8%) ø 41616 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 408872 (19%) ø 30096 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 388848 (18%) ø 30072 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 365284 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 366488 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 386080 (18%) ø 30344 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 370556 (17%) ø 30064 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 371716 (17%) ø 30064 (5%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 94048 (4%) ø 22568 (4%) ø
spike_lk_audio ✔️ ✅ ✅ 135196 (6%) ø 25144 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198572 (9%) ø 58712 (11%) ø
spike_lk_ble ✔️ ✅ ✅ 237196 (11%) ø 39264 (7%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152392 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88480 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 203036 (9%) ø 62048 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138932 (6%) ø 25136 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88044 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 92884 (4%) ø 22832 (4%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154048 (7%) ø 25496 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331308 (15%) ø 38232 (7%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ ✅ ✅ 174168 (8%) ø 47992 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 172332 (8%) ø 57464 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115772 (5%) ø 25184 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 23408 (4%) ø
spike_lk_motors ✔️ ✅ ✅ 86072 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ ✅ ✅ 91572 (4%) ø 22776 (4%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112316 (5%) ø 25184 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84080 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87184 (4%) ø 23280 (4%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90400 (4%) ø 22192 (4%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91672 (4%) ø 22456 (4%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136316 (6%) ø 25056 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 22232 (4%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 148044 (7%) ø 26064 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87320 (4%) ø 24120 (4%) ø
spike_lk_wifi ✔️ ✅ ✅ 130832 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-11-25 11:54:51.467332743 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-11-25 11:54:51.839339799 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       622(+622) |     18(+18) |     248(+248) |
+| [fill]                     |       638(+638) |     18(+18) |     248(+248) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       638(+638) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1544(+1544) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       596(+596) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       924(+924) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 174476(+174476) |   773(+773) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               | 121258(+121258) |   548(+548) | 36294(+36294) |
-| Subtotals                  | 427684(+427684) | 3944(+3944) | 87592(+87592) |
+| main.cpp.obj               | 121818(+121818) |   548(+548) | 36294(+36294) |
+| Subtotals                  | 428260(+428260) | 3944(+3944) | 87592(+87592) |
 Total Static RAM memory (data + bss): 91536(+91536) bytes
-Total Flash memory (text + data): 431628(+431628) bytes
+Total Flash memory (text + data): 432204(+432204) bytes
 
Flash used: 471604&nbsp;(22%) / total: 2097152
SRAM used: 91904&nbsp;(17%) / total: 524288

@YannLocatelli YannLocatelli force-pushed the yann/feature/rc-add-filexchange-state-and-actions branch from c371bc2 to 6569586 Compare November 18, 2022 10:30
@YannLocatelli YannLocatelli force-pushed the yann/feature/sm/update-state-from-file-exchange-state branch from a375023 to 6c3a237 Compare November 18, 2022 10:33
ladislas
ladislas approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

HPezz
HPezz reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@HPezz HPezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one thing to discuss about a remaining transition "charging -> updating"

libs/RobotKit/include/StateMachine.h Outdated
, sm::state::file_exchange + event<sm::event::ble_disconnection> [sm::guard::is_not_charging {}] = sm::state::idle
, sm::state::file_exchange + event<sm::event::ble_disconnection> [sm::guard::is_charging {}] = sm::state::charging
, sm::state::file_exchange + event<sm::event::emergency_stop> = sm::state::emergency_stopped
, sm::state::file_exchange + event<sm::event::update_requested> [sm::guard::is_ready_to_update {}] = sm::state::updating
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion

To keep in mind : With this transition added, we need to decide if the" charging -> update" transition is still useful.
Currently, LekaUpdater send files to the robot then start the update once all the files are sent.

@YannLocatelli YannLocatelli mentioned this pull request Nov 23, 2022
Closed
3 tasks
@YannLocatelli YannLocatelli force-pushed the yann/feature/rc-add-filexchange-state-and-actions branch from 6569586 to 6a3132c Compare November 24, 2022 14:53
@YannLocatelli YannLocatelli force-pushed the yann/feature/sm/update-state-from-file-exchange-state branch from 6c3a237 to ad4cc6b Compare November 24, 2022 14:56
@YannLocatelli YannLocatelli force-pushed the yann/feature/rc-add-filexchange-state-and-actions branch from 6a3132c to 91fabb3 Compare November 25, 2022 11:41
@YannLocatelli YannLocatelli force-pushed the yann/feature/sm/update-state-from-file-exchange-state branch from ad4cc6b to 64b68f0 Compare November 25, 2022 11:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Base automatically changed from yann/feature/rc-add-filexchange-state-and-actions to develop November 25, 2022 15:02
@ladislas ladislas merged commit f4605ce into develop Nov 25, 2022
@ladislas ladislas deleted the yann/feature/sm/update-state-from-file-exchange-state branch November 25, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HPezz HPezz HPezz left review comments

@ladislas ladislas ladislas approved these changes

Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
3 participants
@YannLocatelli @ladislas @HPezz