Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Sending file process might crash the BLE when image or video is displayed #1050

Closed
2 tasks done
YannLocatelli opened this issue Oct 3, 2022 · 5 comments
Closed
2 tasks done

🐛 Sending file process might crash the BLE when image or video is displayed #1050

YannLocatelli opened this issue Oct 3, 2022 · 5 comments
Labels
01 - type: bug Report a bug or issue
Milestone
v1.3.0

Comments

@YannLocatelli
Copy link
Member

YannLocatelli commented Oct 3, 2022 •
edited
Loading

  • Confirm BLE crash when file is sent and video is played (play reinforcer during sending file process)
  • Fix by creating a new state or adding it to Updating state
    • Disabled any new image or video to be displayed
    • Stop process of sending file when quitting state (e.g. robot stop charging)
@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Oct 3, 2022
@YannLocatelli YannLocatelli added this to the Future Release milestone Oct 3, 2022
@YannLocatelli YannLocatelli added 01 - type: bug Report a bug or issue and removed 01 - type: task Something to do labels Oct 4, 2022
@YannLocatelli
Copy link
Member Author

BLE crash confirmed

See

This was referenced Nov 17, 2022
Merged
Merged
Merged
Merged
@ladislas ladislas modified the milestones: Future Release, v1.3.0 Dec 2, 2022
@YannLocatelli
Copy link
Member Author

Partially fixed thanks to

@YannLocatelli
Copy link
Member Author

Need non-regression tests, see

@YannLocatelli
Copy link
Member Author

thinking about it, the issue with sha256 might be same as the issue with file exchange: when reading from sd card, it took too much time for BLE to process/send the data and it caused the crash.

#1195 (review) (@ladislas)

@YannLocatelli
Copy link
Member Author

Solved with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 - type: bug Report a bug or issue
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@ladislas @YannLocatelli