-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create correct url when using ipv6 #753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for fixing it 🙌
Please fix warnings found by linters. |
Done! I did the PR not from my usual system and I had no linters installed 🤦🏼♂️ |
There is another warning about using Hassfest errors are unrelated to this change. |
Ok, I've ended up installing pre-commit it locally. I missed that one in the action log. That should be it. Sorry for the noise. |
Hello, just a note. This error does not appear only when IPv6 is used. Anyway it looks like this PR fixes my issue also so thank you very much @skgsergio |
It seems zeroconf may return ipv6 addresses sometimes when discovering Google Home devices. I guess it should be possible to disable this in zeroconf or make this configurable from integration settings. If someone is interested in working on this, PR is welcome. |
i also noticed that we are a few minor versions behind with zeroconf leikoilja/glocaltokens#437 , so might be worth checking the release notes if there were meaningful fixes |
Currently when using IPv6 I get the following errors:
This is due to a malformed URL when using IPv6, as the IPv6 needs to be placed between
[]
, for examplehttps://[2a02:9140:4d80:xxxx:3944:b4e3:bed3:fce]:8443/setup/assistant/notifications
.This PR detects if the IP is IPv6 and adds them.