Skip to content

Commit

Permalink
ipq40xx: fix I2C pin config on Aruba AP-303H
Browse files Browse the repository at this point in the history
Turn on SoC pull-ups on I2C pins, since there are no discrete pull-up
resistors on the bus.

Increase clock to 400 kHz. Both chips on the bus support 400 kHz. I
tested the ISL28022 at 4,000 reads/sec and didn't see any garbled output
or bus hangs, even with SoC drive strength reduced to 2 for the test.

Signed-off-by: Ryan Salsbury <[email protected]>
Link: openwrt/openwrt#15334
Signed-off-by: Robert Marko <[email protected]>
  • Loading branch information
ryanrsrs authored and robimarko committed Apr 30, 2024
1 parent 0f5da39 commit 47da178
Showing 1 changed file with 23 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,25 +71,6 @@
watchdog@b017000 {
status = "okay";
};

i2c_0: i2c@78b7000 {
pinctrl-0 = <&i2c_0_pins>;
pinctrl-names = "default";
status = "okay";

tpm@29 {
/* No Driver */
compatible = "atmel,at97sc3203";
reg = <0x29>;
read-only;
};

power-monitor@40 {
/* No driver */
compatible = "isl,isl28022";
reg = <0x40>;
};
};
};

leds {
Expand Down Expand Up @@ -214,7 +195,7 @@
pins = "gpio20", "gpio21";
function = "blsp_i2c0";
drive-strength = <4>;
bias-disable;
bias-pull-up;
};
};

Expand Down Expand Up @@ -242,6 +223,28 @@
};
};

&blsp1_i2c3 {
pinctrl-0 = <&i2c_0_pins>;
pinctrl-names = "default";
status = "okay";
clock-frequency = <400000>;

tpm@29 {
/* No Driver */
compatible = "atmel,at97sc3203";
reg = <0x29>;
read-only;
};

power-monitor@40 {
/* No driver */
/* Device also replies on address 0x3f, see */
/* ISL28022 datasheet, "Broadcast Addressing" */
compatible = "isl,isl28022";
reg = <0x40>;
};
};

&blsp1_spi1 {
pinctrl-0 = <&spi_0_pins>;
pinctrl-names = "default";
Expand Down

0 comments on commit 47da178

Please sign in to comment.