add OCR / translation #24
Conversation
fixed docu
| dir.create(output_dir_name,showWarnings = F) | ||
| writeLines(x,file(paste0(dirname(path),"/outputs/",basename(path),".txt")) ) |
There was a problem hiding this comment.
@behrica I'm a bit wary of this piece of code to create the directory and write the lines to that directory without the user directly specifying the directory or opting in to saving the results. I saw similar code earlier on too, is this piece needed for the OCR?
There was a problem hiding this comment.
The reason for this is traceability.
My users like the fact, that the magic of the OCR + translation becomes visible in the form of files,
so they can archive the whole folder of original PDFs + OCR result + translation result.
This can eventually later explain, why certain things have not been found., which is important in our context.
Maybe there is a better way to do this in R.
There was a problem hiding this comment.
we could have an option to enable or disable this.
Same is true for progress logging.
As the eventually large pdfs gets uploaded to Azure, the "search" on lots of files could take hours.
(I implemented some caching, so a second search will not do it anymore),
Do you have a suggestion for this ?
Co-authored-by: Brandon LeBeau <[email protected]>
cleaned up some commented code replaced T -> TRUE, F -> FALSE
|
I cleaned up the code, used argument lists and replaced T -> TRUE, F-> FALSE |
|
I am aware, that I am not a good R programmer, more an R user, My PR is in this sense as well more a "proof of concept" then "ready made code", For my colleges this is a real time safer. |
new PR as requested