Feat/multiples inputs #11
Conversation
| @@ -10,7 +10,7 @@ import ( | |||
| ) | |||
|
|
|||
| func Build(m mosaic.Mosaic, cfg *config.Config) []string { | |||
| playlistPath := fmt.Sprintf("hls/%s/playlist.m3u8", m.Name) | |||
| playlistPath := fmt.Sprintf("hls/%s/playlist-%s.m3u8", m.Name, m.Name) | |||
There was a problem hiding this comment.
Why repeating the name of the mosaic again?
There was a problem hiding this comment.
hls/mosaicname/playlist.m3u8
This is how the path looks like. It works for HLS.
There was a problem hiding this comment.
To make unique each mosaic configured in tasks.json, because if you create a new mosaic object and maintains a playlist.m3u8 name, the final result will be mixed into a unique HLS output, therefore into HLS player, I can to change the manifest.
There was a problem hiding this comment.
Now I get what you are saying. But the answer for this problem is creating a new bucket. Every mosaic should have its own bucket, then, for example:
- mosaic1 will have its files in mosaic1 bucket
- mosaic2 will have its files in mosaic2 bucket
There was a problem hiding this comment.
I'm not sure when the bucket should be created. Probably just before starting the ffmpeg process
There was a problem hiding this comment.
Or we can to create only one bucket, like hls or objects and use the prefixes to organize fragments, see how this works in AWS S3 article.
What do you think?
There was a problem hiding this comment.
Look this:
Basically, join the folder name + filename and upload object:
This way we'll have one bucket organized by prefixes.
| @@ -40,14 +40,25 @@ func Build(m mosaic.Mosaic, cfg *config.Config) []string { | |||
|
|
|||
| filterComplexBuilder.WriteString(fmt.Sprintf("[image]%s overlay=shortest=0 [mosaic]", lastOverlay)) | |||
|
|
|||
| videoInputs := []string{} | |||
| for _, m := range m.Medias { | |||
| ) { | ||
| lifecycle.Append(fx.Hook{ | ||
| OnStart: func(ctx context.Context) error { | ||
| r := mux.NewRouter() | ||
| r.Handle("/playlist/{filename}", playlistHandler).Methods("GET") | ||
| r.Handle("/fragment/{filename}", fragmentHandler).Methods("GET") | ||
| r.Handle("/player", playerHandler).Methods("GET") | ||
| r.Handle("/manifest", manifestHandler).Methods("GET") |
There was a problem hiding this comment.
I did not understand the reason behind this endpoint, sorry. Could you explain?
There was a problem hiding this comment.
Also, I think we can use just one handler and pass the request path to the storage. What is your opinion?
There was a problem hiding this comment.
I created this new endpoint to serve a custom json with all mosaics playlist.m3u8 and can possible to create a button for each mosaic registered:
Manifest response based in tasks.json:
[
{
"name": "mosaic",
"playlist_url": "http://localhost:8090/playlist/playlist-mosaic.m3u8"
},
{
"name": "mosaic2",
"playlist_url": "http://localhost:8090/playlist/playlist-mosaic2.m3u8"
}
]On HLS player, i can mount this:
There was a problem hiding this comment.
But, now i revised and HLS player use same endpoint to get playlist and fragment (/player/playlist/filename), then we need only two endpoints:
- GET /playlist
- GET /manifest
|
Could you split this PR into differents features/fixes? (not sure if that manifest change makes sense) |
Of course, i'll split this changes in another branchs to make easy a maintainability. Related to manifest change, we can to discuss another ways to make this. |
|
@luiscovelo given the last PRs, how many changes in this PR will be kept? Thank you for your contributions! |
We don't need kept this PR, because i split into new PR's merged in branch main. Related about manifest endpoint, with theses new changes applied into main, i can to create a new handler to return a custom object for HLS player, containing all mosaics playlist, based in tasks.json, like this: [
{
"name": "mosaic",
"playlist_url": "http://localhost:8090/playlist/playlist-mosaic.m3u8"
},
{
"name": "mosaic2",
"playlist_url": "http://localhost:8090/playlist/playlist-mosaic2.m3u8"
}
]And to mount a button for each mosaic returned. Like this:
I guess creating this new endpoint makes it dynamic for HLS player. What do you think? |
|
It looks like a good idea. Would this feature be useful just for testing, right? |
|
I had thinking as a feature in case the user to have more than one mosaic registered. How do you think to do so that the user can switch their mosaics for viewing? |
|
@luiscovelo well, if someone/company is going to use this project, they will integrate in their own players. |
|
Of course, you are right, don't make a sense implement this endpoint, for testing, one mosaic entry will be enough. |
Hi, @mauricioabreu.
I fix the command builder to mount dynamic video inputs;
I created a manifest handler to serve a hls player a custom result containing all mosaics from tasks.json;
I update hls player to show buttons options reference each mosaic;
See this video with hls player updated: HLS player working.
Best reguards.