test: Fix FFMPEG command assert

learn-video · Jan 11, 2024 · e49468d · e49468d
1 parent 607f0f1
commit e49468d
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 14 deletions.
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -10,7 +10,6 @@ type Config struct {
 	API struct {
 		URL string
 	}
-	AssetsPath  string
 	StaticsPath string
 	S3          struct {
 		Endpoint        string
@@ -45,7 +44,6 @@ func NewConfig() *Config {
 			SecretAccessKey: os.Getenv("S3_SECRET_ACCESS_KEY"),
 			BucketName:      os.Getenv("S3_BUCKET_NAME"),
 		},
-		AssetsPath:  os.Getenv("ASSETS_PATH"),
 		StaticsPath: os.Getenv("STATICS_PATH"),
 	}
 }
diff --git a/internal/mosaic/mosaic_test.go b/internal/mosaic/mosaic_test.go
@@ -54,7 +54,6 @@ func TestBuildFFMPEGCommand(t *testing.T) {
 				"-hls_playlist_type", "event",
 				"-hls_time", "5",
 				"-strftime", "1",
-				"-hls_segment_filename", "hls/mosaicvideo/seg_%s.ts",
 				"-method", "PUT",
 				"-http_persistent", "1",
 				"-sc_threshold", "0",

diff --git a/internal/worker/worker.go b/internal/worker/worker.go
@@ -2,7 +2,6 @@ package worker
 
 import (
 	"context"
-	"os"
 	"time"
 
 	"github.com/mauricioabreu/mosaic-video/internal/config"
@@ -11,15 +10,7 @@ import (
 	"github.com/mauricioabreu/mosaic-video/internal/mosaic/command"
 )
 
-func createPath(path string) error {
-	return os.MkdirAll(path, os.ModePerm)
-}
-
 func GenerateMosaic(m mosaic.Mosaic, cfg *config.Config, locker locking.Locker, cmdExecutor mosaic.Command, runningProcesses map[string]bool) error {
-	if err := createPath(cfg.AssetsPath + "/" + m.Name); err != nil {
-		return err
-	}
-
 	_, exists := runningProcesses[m.Name]
 	if exists {
 		return nil

diff --git a/internal/worker/worker_test.go b/internal/worker/worker_test.go
@@ -22,7 +22,7 @@ func TestGenerateMosaicWhenLockingFails(t *testing.T) {
 			{URL: "http://example.com/mosaicvideo_2.m3u8"},
 		},
 	}
-	cfg := &config.Config{AssetsPath: "output"}
+	cfg := &config.Config{}
 	locker.EXPECT().Obtain(gomock.Any(), "mosaicvideo", gomock.Any()).Return(nil, errors.New("error obtaining lock"))
 	runningProcesses := make(map[string]bool)
 
@@ -38,7 +38,7 @@ func TestGenerateMosaicWhenLockingFails(t *testing.T) {
 }
 
 func TestGenerateMosaicWhenExecutingCommandFails(t *testing.T) {
-	cfg := &config.Config{AssetsPath: "output"}
+	cfg := &config.Config{}
 	ctrl := gomock.NewController(t)
 	locker := mocks.NewMockLocker(ctrl)
 	mosaic := mosaic.Mosaic{