New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: return response from callback #138

Merged

mesaugat merged 4 commits into main from fix/return-from-callback

Aug 21, 2024

Collaborator

HiteshShrestha commented Aug 20, 2024 •

edited

Loading

This PR

updates the initialize method to return the response from the callback.
adds in test cases for error handling to check if the rejected promise and error thrown is bubbled up or not.

Note: The test run will output a warning since we are using Deprecated Domain module.
(node:88196) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated..


          Fix: return response from callback

4a4005b

HiteshShrestha requested review from mesaugat and pravat11

August 20, 2024 11:07

HiteshShrestha self-assigned this

mesaugat reviewed

View reviewed changes

test/domain.test.ts Outdated Show resolved Hide resolved

mesaugat reviewed

View reviewed changes

test/domain.test.ts Show resolved Hide resolved

mesaugat reviewed

View reviewed changes

test/domain.test.ts Outdated Show resolved Hide resolved

mesaugat reviewed

View reviewed changes

test/domain.test.ts Outdated Show resolved Hide resolved

mesaugat reviewed

View reviewed changes

test/domain.test.ts Show resolved Hide resolved

HiteshShrestha added 2 commits

August 21, 2024 14:15


          Test update and resolution for PR comments

c642fa4


          Update doc and interface

be02235

HiteshShrestha requested a review from mesaugat

August 21, 2024 09:20

mesaugat reviewed

View reviewed changes

test/domain.test.ts Outdated Show resolved Hide resolved

mesaugat reviewed

View reviewed changes

test/domain.test.ts Outdated Show resolved Hide resolved

mesaugat reviewed

View reviewed changes

test/domain.test.ts Show resolved Hide resolved

Member

mesaugat commented Aug 21, 2024

@HiteshShrestha Looking good. I have added a few comments. Let's also run yarn prettify so that the formatting of files is correct with the prettier version in package.json.


          Add a test to verify response from non-async callback function

cd44aec

HiteshShrestha requested a review from mesaugat

August 21, 2024 10:11

mesaugat approved these changes

View reviewed changes

mesaugat merged commit d0e5da9 into main

4 checks passed

mesaugat deleted the fix/return-from-callback branch

August 21, 2024 10:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet