-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: define Squash
as a Quotient
#6642
base: master
Are you sure you want to change the base?
Conversation
Mathlib CI status (docs):
|
@vihdzp, you can add the (newly required) |
Please rebase onto |
@kim-em FYI, I don't have permission to add labels myself. |
The breakage here is due to |
If you add a comment containing just a label name, a bot automatically adds the corresponding label for you. |
This PR changes the definition of
Squash
to useQuotient
by upstreamingtrue_equivalence
(nowequivalence_true
) andtrueSetoid
(nowSetoid.trivial
). The new definition is def-eq to the old one, but ensures thatSquash
can be used whenever aQuotient
argument is expected without having to explicitly provide the setoid.Besides being useful functionality, this makes Mathlib's
Trunc
completely equivalent toSquash
. Mathlib PR #18952 will deprecate the former in favor of the latter.