Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce Eq.rec when mvars are present #6577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reduce Eq.rec when mvars are present #6577

wants to merge 1 commit into from

Conversation

cppio
Copy link
Contributor

@cppio cppio commented Jan 8, 2025

This PR allows K-like reduction (used when reducing Eq.rec) when metavariables are present.

Closes #6562

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 8, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6577
4c5675d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 8, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6577
8100f74
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 8, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 8, 2025 •
edited
Loading

Mathlib CI status (docs):

cppio added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 9, 2025
@cppio
fix build for leanprover/lean4#6577
aa3ade5
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Jan 9, 2025
@cppio
Copy link
Contributor Author

cppio commented Jan 9, 2025

changelog-language

@github-actions github-actions bot added the changelog-language Language features, tactics, and metaprograms label Jan 9, 2025
@cppio cppio marked this pull request as ready for review January 9, 2025 15:23
@nomeata
Copy link
Collaborator

nomeata commented Jan 10, 2025 •
edited
Loading

I noticed that you had to add set_option maxHeartbeats 400000 in in mathlib after your change. Maybe that hints at the reason for the code as it was before?

@leanprover-bot leanprover-bot added the P-low We are not planning to work on this issue label Jan 10, 2025
@kim-em
Copy link
Collaborator

kim-em commented Jan 16, 2025

I noticed that you had to add set_option maxHeartbeats 400000 in in mathlib after your change. Maybe that hints at the reason for the code as it was before?

Oh dear -- and as a general principle, if you get Mathlib to build, but it requires maxHeartbeats or significant adaptations, please report on that back here on the PR thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms P-low We are not planning to work on this issue toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

match elaboration fails to unify definitionally equal types
5 participants
@cppio @leanprover-community-bot @nomeata @kim-em @leanprover-bot