Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: verify insertMany method for adding lists to HashMaps #6211

Merged
merged 86 commits into from
Jan 15, 2025
Merged

feat: verify insertMany method for adding lists to HashMaps #6211

merged 86 commits into from
Jan 15, 2025

Conversation

monsterkrampe
Copy link
Contributor

This PR verifies the insertMany method on HashMaps for the special case of inserting lists.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 25, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 25, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 935fcfb6ec84342163a86058856edcb1dca70ff4 --onto 884a9ea2ff70bb4d0c6da4a1c23ffc26c3a974ee. (2024-11-25 13:30:54)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0a22f8fa6fef34a6798785785237c66cab173197 --onto 9a17919ef11c2dba824498229633b8333a0b53d9. (2024-11-26 15:53:38)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b378fe98a7877276b7dff70527b6c924e672c435 --onto 9a17919ef11c2dba824498229633b8333a0b53d9. (2024-11-27 15:47:35)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b378fe98a7877276b7dff70527b6c924e672c435 --onto 609346f5e03f3f2d559e7cc905f72e950c3ed8c4. (2024-11-28 08:49:25)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b378fe98a7877276b7dff70527b6c924e672c435 --onto 6d495586a1836da3e12efb4fbf9946bd9088ac5f. (2024-11-29 10:41:50)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b378fe98a7877276b7dff70527b6c924e672c435 --onto 86f303774a7fbf38406ae13bd4b66f2753643a45. (2024-11-30 15:42:21)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b378fe98a7877276b7dff70527b6c924e672c435 --onto 27df5e968a675780a7bcd105a19774c0c59295d8. (2024-12-01 19:35:29)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b378fe98a7877276b7dff70527b6c924e672c435 --onto 3c5e612dc54733cd707becb929457d2f9d8ca6fd. (2024-12-02 15:27:36)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 3c5e612dc54733cd707becb929457d2f9d8ca6fd. (2024-12-02 22:28:30)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto cb600ed9b436e4290b819b0529f8454490bffeb6. (2024-12-03 16:10:17)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 019f8e175f9650b829aca8ee501f41c0a5d9076d. (2024-12-05 15:37:52)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 8a3a806b1a8a1f0de8868c5bf96375b5dd6581fd. (2024-12-10 18:29:24)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 8709ca35e9ddb977f7d050751e04981e2ab0d5c7. (2024-12-11 11:07:25)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 48be424eaa2ae06972e9cfec4d355906b532204d. (2024-12-12 18:12:24)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto a8a160b09147c3225150703ac727eea6ee9a3b0e. (2024-12-15 19:38:27)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d9d54c1f99363f42d1485f6b67f281a5985f684e --onto 6a839796fd537d14055e4a51a78c5272a1b52fb8. (2024-12-28 15:45:57)
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2024-12-28 18:08:08) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-05 18:03:16) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-05 20:19:35) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-05 21:40:27) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-05 22:37:08) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-06 11:36:22) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-08 10:57:15) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-08 12:02:28) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-08 18:58:27) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-09 11:48:05) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-09 14:38:10) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-09 15:43:58) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-10 11:39:53) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-10 22:03:45) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-13 08:07:54) View Log
  • ✅ Mathlib branch lean-pr-testing-6211 has successfully built against this PR. (2025-01-13 09:22:47) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 821c9b7af9039947ba9def0efac9e653e855c108 --onto d2c4471cfa4611977bf4927b5cd849df1a4272b7. (2025-01-14 10:38:52)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 821c9b7af9039947ba9def0efac9e653e855c108 --onto e9bd9807ef7a983365df9ac55d35040d0b2d5ef2. (2025-01-14 16:13:59)

@TwoFX TwoFX self-assigned this Nov 26, 2024
TwoFX
TwoFX requested changes Nov 26, 2024
View reviewed changes
src/Std/Data/DHashMap/Basic.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/List/Associative.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/List/Associative.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Internal/RawLemmas.lean Outdated Show resolved Hide resolved
jt0202 and others added 17 commits November 27, 2024 15:35
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 10, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
95c0ca3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 10, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
475989b
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 10, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
ff94444
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 10, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
f00d20e
@monsterkrampe monsterkrampe marked this pull request as ready for review January 13, 2025 07:03
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 13, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
4439dd6
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 13, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
ae0aab3
@jt0202
Copy link
Contributor

jt0202 commented Jan 13, 2025

changelog-library

@github-actions github-actions bot added the changelog-library Library label Jan 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 13, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
f7a9129
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 13, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6211
6432ae2
TwoFX
TwoFX reviewed Jan 13, 2025
View reviewed changes
src/Std/Data/DHashMap/Basic.lean Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Outdated Show resolved Hide resolved
@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Jan 14, 2025
TwoFX
TwoFX reviewed Jan 15, 2025
View reviewed changes
src/Std/Data/DHashMap/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/DHashMap/Lemmas.lean Outdated Show resolved Hide resolved
src/Std/Data/HashSet/Lemmas.lean Outdated Show resolved Hide resolved
TwoFX
TwoFX approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you so much!

@TwoFX TwoFX added this pull request to the merge queue Jan 15, 2025
@monsterkrampe
Copy link
Contributor Author

Our pleasure! It was fun and very insightful :)
Thanks for your thorough reviews as well!

Merged via the queue into leanprover:master with commit 6665837 Jan 15, 2025
14 checks passed
@jt0202
Copy link
Contributor

jt0202 commented Jan 16, 2025

Thanks from my side as well for all the reviews and your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jt0202 jt0202 jt0202 left review comments

@kim-em kim-em kim-em left review comments

@TwoFX TwoFX TwoFX approved these changes

Assignees

@TwoFX TwoFX

Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@monsterkrampe @leanprover-community-bot @jt0202 @kim-em @TwoFX @leanprover-bot