-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Order/Nucleus): nuclei form a complete lattice #21515
Conversation
PR summary 76b084dd70Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I think this can be golfed
Co-authored-by: Yaël Dillies <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a final golf. LGTM, thanks! 🚀
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Arbitrary meets of nuclei can be defined pointwise. Joins are harder to describe explicitely, so `completeLatticeOfCompleteSemilatticeInf` is used to create the `CompleteLattice` instance. Co-authored-by: Bergschaf <[email protected]> Co-authored-by: Yaël Dillies <[email protected]>
Pull request successfully merged into master. Build succeeded: |
Arbitrary meets of nuclei can be defined pointwise. Joins are harder to describe explicitely, so
completeLatticeOfCompleteSemilatticeInf
is used to create theCompleteLattice
instance.