Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Order/Nucleus): nuclei form a complete lattice #21515

Closed
wants to merge 16 commits into from

Conversation

Bergschaf
Copy link
Collaborator

@Bergschaf Bergschaf commented Feb 6, 2025

Arbitrary meets of nuclei can be defined pointwise. Joins are harder to describe explicitely, so completeLatticeOfCompleteSemilatticeInf is used to create the CompleteLattice instance.


Open in Gitpod

@github-actions github-actions bot added the t-order Order theory label Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

PR summary 76b084dd70

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ iInf_apply
+ instance : CompleteLattice (Nucleus X) := completeLatticeOfCompleteSemilatticeInf (Nucleus X)
+ instance : CompleteSemilatticeInf (Nucleus X)
+ instance : InfSet (Nucleus X)
+ monotone
+ sInf_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Bergschaf Bergschaf requested a review from YaelDillies February 6, 2025 17:13
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think this can be golfed

Mathlib/Order/Nucleus.lean Outdated Show resolved Hide resolved
Mathlib/Order/Nucleus.lean Outdated Show resolved Hide resolved
Mathlib/Order/Nucleus.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 6, 2025
@YaelDillies YaelDillies changed the title feat(Order/Nucleus): The Nuclei form a CompleteLattice feat(Order/Nucleus): nuclei form a complete lattice Feb 6, 2025
@Bergschaf Bergschaf removed the awaiting-author A reviewer has asked the author a question or requested changes label Feb 6, 2025
Co-authored-by: Yaël Dillies <[email protected]>
Mathlib/Order/Nucleus.lean Outdated Show resolved Hide resolved
Mathlib/Order/Nucleus.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a final golf. LGTM, thanks! 🚀

maintainer merge

Copy link

github-actions bot commented Feb 7, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Feb 7, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 7, 2025
Arbitrary meets of nuclei can be defined pointwise. Joins are harder to describe explicitely, so `completeLatticeOfCompleteSemilatticeInf` is used to create the `CompleteLattice` instance.



Co-authored-by: Bergschaf <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 7, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Nucleus): nuclei form a complete lattice [Merged by Bors] - feat(Order/Nucleus): nuclei form a complete lattice Feb 7, 2025
@mathlib-bors mathlib-bors bot closed this Feb 7, 2025
@mathlib-bors mathlib-bors bot deleted the Nucleus_sInf branch February 7, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants