Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and mk #18178

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

yoh-tanimoto
Copy link
Collaborator

@yoh-tanimoto yoh-tanimoto commented Oct 24, 2024

Define the mk and lifts of normed spaces and normed groups by the inseparable setoid as NormedAddGroupHom, CLM, etc.

Motivation: In the GNS representation, operators in the original C^*-algebra are represented as bounded linear operators.

This PR splits from #16707.

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

messageFile.md

@yoh-tanimoto yoh-tanimoto added awaiting-CI t-analysis Analysis (normed *, calculus) labels Oct 24, 2024
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 24, 2024
@yoh-tanimoto yoh-tanimoto added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 24, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 24, 2024
@yoh-tanimoto yoh-tanimoto added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 25, 2024
@yoh-tanimoto yoh-tanimoto added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 25, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 25, 2024
@yoh-tanimoto
Copy link
Collaborator Author

I'm not sure, as for Mathlib.Topology.Algebra.SeparationQuotient.Basic, I added Mathlib.Topology.Algebra.ContinuousMonoidHom which is necessary because I define liftContinuousMonoidHom. I don't understand Mathlib.Analysis.Normed.Group.Hom, I don't add any import?

Copy link

messageFile.md

@YaelDillies
Copy link
Collaborator

Can you merge master to fix the bot?

Copy link

github-actions bot commented Jan 29, 2025

PR summary f55a802e8a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Algebra.SeparationQuotient.Hom (new file) 1195
Mathlib.Analysis.Normed.Group.SeparationQuotient (new file) 1313

Declarations diff

+ apply_eq_apply_of_inseparable
+ instance : ContinuousMapClass (NormedAddGroupHom V₁ V₂) V₁ V₂
+ liftCLM
+ liftCLM_mk
+ liftContinuousCommMonoidHom_mk
+ liftContinuousMonoidHom
+ liftNormedAddGroupHom
+ liftNormedAddGroupHom_equiv
+ liftNormedAddGroupHom_normNoninc
+ liftNormedAddGroupHom_norm_le
+ nhds_mk
+ norm_liftNormedAddGroupHom_apply_le
+ norm_liftNormedAddGroupHom_le
+ norm_normedMk_eq_one
+ norm_normedMk_le
+ normedMk
+ normedMk_eq_zero
+ ofClass

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies
Copy link
Collaborator

YaelDillies commented Jan 29, 2025

for Mathlib.Topology.Algebra.SeparationQuotient.Basic, I added Mathlib.Topology.Algebra.ContinuousMonoidHom which is necessary because I define liftContinuousMonoidHom

Can you maybe move liftContinuousMonoidHom to a new file Mathlib.Topology.Algebra.SeparationQuotient.Hom? The import increases are currently unacceptably large

@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 30, 2025
@yoh-tanimoto yoh-tanimoto added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 30, 2025
@yoh-tanimoto
Copy link
Collaborator Author

Thanks, I splitted the file and now it seems ok?

Mathlib/Topology/Algebra/SeparationQuotient/Basic.lean Outdated Show resolved Hide resolved
@@ -195,6 +195,11 @@ instance instGroup [Group G] [TopologicalGroup G] : Group (SeparationQuotient G)
instance instCommGroup [CommGroup G] [TopologicalGroup G] : CommGroup (SeparationQuotient G) :=
surjective_mk.commGroup mk mk_one mk_mul mk_inv mk_div mk_pow mk_zpow

/-- Neighborhoods in the quotient are precisely the map of neighborhoods in the prequotient. -/
theorem nhds_mk_eq (x : G) :
nhds (mk x) = Filter.map mk (nhds x) :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the notation?

Suggested change
nhds (mk x) = Filter.map mk (nhds x) :=
𝒩 (mk x) = .map mk (𝒩 x) :=

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails, does it mean that I should import something?

Mathlib/Topology/Algebra/SeparationQuotient/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/SeparationQuotient/Basic.lean Outdated Show resolved Hide resolved
Comment on lines 386 to 390
variable {A} in
@[to_additive]
instance (F : Type*) [FunLike F A B] [ContinuousMapClass F A B] [MonoidHomClass F A B] :
CoeOut F (ContinuousMonoidHom A B) where
coe := toContinuousMonoidHom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to get rid of those coercions, see #21031. Can you replace this by a function ContinuousMonoidHom.ofClass if you really need it? More likely, you don't actually need it and can write something.toContinuousMonoidHom instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added this because it was asked here #18178 (comment)

What should I do? I added a def for the moment

Mathlib/Topology/Algebra/SeparationQuotient/Hom.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/SeparationQuotient/Hom.lean Outdated Show resolved Hide resolved
Comment on lines 70 to 71
(hf : ∀ x, ‖x‖ = 0 → f x = 0) : NormedAddGroupHom (SeparationQuotient M) N :=
{ SeparationQuotient.liftContinuousAddMonoidHom f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use where here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Mathlib/Analysis/Normed/Group/SeparationQuotient.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 30, 2025
@yoh-tanimoto yoh-tanimoto removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants