-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and mk
#18178
base: master
Are you sure you want to change the base?
Conversation
messageFile.md |
Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
Co-authored-by: Eric Wieser <[email protected]>
I'm not sure, as for |
This reverts commit 1aef174.
messageFile.md |
Can you merge master to fix the bot? |
…tionquotient-lift
PR summary f55a802e8aImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Can you maybe move |
Thanks, I splitted the file and now it seems ok? |
@@ -195,6 +195,11 @@ instance instGroup [Group G] [TopologicalGroup G] : Group (SeparationQuotient G) | |||
instance instCommGroup [CommGroup G] [TopologicalGroup G] : CommGroup (SeparationQuotient G) := | |||
surjective_mk.commGroup mk mk_one mk_mul mk_inv mk_div mk_pow mk_zpow | |||
|
|||
/-- Neighborhoods in the quotient are precisely the map of neighborhoods in the prequotient. -/ | |||
theorem nhds_mk_eq (x : G) : | |||
nhds (mk x) = Filter.map mk (nhds x) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use the notation?
nhds (mk x) = Filter.map mk (nhds x) := | |
𝒩 (mk x) = .map mk (𝒩 x) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails, does it mean that I should import something?
variable {A} in | ||
@[to_additive] | ||
instance (F : Type*) [FunLike F A B] [ContinuousMapClass F A B] [MonoidHomClass F A B] : | ||
CoeOut F (ContinuousMonoidHom A B) where | ||
coe := toContinuousMonoidHom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're trying to get rid of those coercions, see #21031. Can you replace this by a function ContinuousMonoidHom.ofClass
if you really need it? More likely, you don't actually need it and can write something.toContinuousMonoidHom
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I added this because it was asked here #18178 (comment)
What should I do? I added a def for the moment
(hf : ∀ x, ‖x‖ = 0 → f x = 0) : NormedAddGroupHom (SeparationQuotient M) N := | ||
{ SeparationQuotient.liftContinuousAddMonoidHom f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use where
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Define the
mk
and lifts of normed spaces and normed groups by the inseparable setoid asNormedAddGroupHom
,CLM
, etc.Motivation: In the GNS representation, operators in the original C^*-algebra are represented as bounded linear operators.
This PR splits from #16707.