Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass ellipsis to scale_x_continuous #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sam217pa
Copy link

@sam217pa sam217pa commented May 2, 2020

Hi,

(This is a really minor pull request.)
I found that I needed to manually make some tweaks to scale_x_sequnit, like setting limits.
Just passing the ellipsis to ggplot2::scale_x_continuous does the job.

This edit was tested locally; it works, unless you explicitely pass breaks to scale_x_sequnit.
Do you think it need to be taken care of?

thanks for ggbio; it is pure gold.

@lawremi
Copy link
Owner

lawremi commented May 4, 2020

Ideally it would check for breaks (or labels). Anyway, please update the man page. Thanks for the contribution.

fix typo in man page (disalbe -> disable)
@sam217pa
Copy link
Author

sam217pa commented May 5, 2020

Done.

I added my name to authors in man page; don't know if it is ok with Bioconductor's policy ?
I don't mind not being mentionned for such a minor contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants