-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMNIST tutorial is added #67
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ahmetakman <[email protected]>
if self.transform is not None: | ||
event = self.transform(event) | ||
spike = event.fill_tensor( | ||
np.zeros((2, 34, 34, self.num_time_bins)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the only difference between the dataloader here and the dataloader for training is this line. So I would suggest deriving this NMNISTdataset class from tutorials.lava.lib.dl.slayer.nmnist.NMNISTdataset and just override the getitem(). It would just be conversion of spike from torch to numpy. spike = spike_torch.cpu().data.numpy()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see; I did not know that NMNIST is included in the library. I just took the NMNIST slayer tutorial as the reference. Thanks for the advice.
@ahmetakman Thanks for contributing the tutorial :). I have a few comments/suggestions on I would like to point you to the existing
|
Actually, I first tried to implement using the ring buffers, but I could not make it work. I need to look back and try again for that. |
I am now available to implement with ring buffers. Since my first attempt was unsuccessful could you provide some informational document (or any useful resource) about ring buffers in LAVA? |
@ahmetakman here is a brief description about RingBuffer sink.
Here are a couple of examples of RingBuffer being used to read and log spikes. |
It has been a while and now I have have time to work on the lava again. It has been a wild semester I thought it will never end. I will look through it to finally finish this pull request. |
Signed-off-by: ahmetakman [email protected]
Issue Number: #66
The objective of pull request: I have created a notebook that implements the conversion of the network created in the Slayer NMNIST tutorial.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Tutorial contribution.
Please check your PR type:
What is the current behavior?
Does this introduce a breaking change?
Supplemental information