Improve parsing of bracketed expressions #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MBS conversion fails while parsing a bracketed expression, we'd end up writing '\0' to `buf[-1]`. Check the result of the conversion. While here, rewrite `tre_parse_bracket_items()` to return immediately on error, instead of lazily checking the status later. This fixes laurikari#51.
Since we now return immediately on error, we don't need an if-else chain. This allows us to unindent a large swath of code.
I meant to include this in a0cafd4 but forgot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to fix #51 (out-of-bounds write when parsing bracketed expressions). It also cleans up the surrounding code and fixes a type nit which I missed in #108.