Desktop: Accessibility: Rich Text Editor: Make it possible to edit code blocks with a keyboard or touchscreen #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See WCAG 2.2 SC 2.1.2 (and laurent22#10795). This commit adds a menu item to the desktop app that allows toggling tab indentation. Associated with this menu item is the standard [ctrl]-[m] keyboard shortcut.
…esktop/accessibility/rte-edit-code-right-click
Comment on lines
119
to
121
| // Katex is a special case with special opening/closing tags | ||
| // and we don't currently handle switching the language in this case. | ||
| disabled: source.language === 'katex', | ||
| enabled: source.language !== 'katex', |
There was a problem hiding this comment.
Changed after replacing an any type with a stronger type: disabled was giving a type error.
| }, | ||
| { | ||
| type: 'textarea', | ||
| name: 'codeTextArea', | ||
| value: source.content, |
There was a problem hiding this comment.
Changed after replacing an any type with a stronger type: value was giving a type error. Removing value does not prevent the edit dialog from opening with an existing code block's content.
personalizedrefrigerator
added
desktop
personalizedrefrigerator
changed the title
pedr
approved these changes
Jan 27, 2025
…esktop/accessibility/rte-edit-code-right-click
…lity/rte-edit-code-right-click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This pull request builds on the changes from #11717. Consider reviewing #11717 before this pull request.
This pull request does two related things:
Previously, it was necessary to double-click code blocks (with a mouse button) to edit them.
Related WCAG guideline: WCAG 2.2, SC 2.1.1: Keyboard.
See #10795.
This pull request supersedes #11723, which did not include automated tests and did not add "Edit" to the context menu.
Related (unresolved) tasks
Testing
Automated tests
New tests: Verify that existing functionality isn't broken — that 1) new code blocks can be created from the toolbar and 2) existing code blocks can be edited by double-clicking.
Manual testing
Verified that (on Ubuntu 24.04):