Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use musl libs for static binary #407

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

hoshsadiq
Copy link
Member

@hoshsadiq hoshsadiq commented Aug 19, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

It was noted that the CLI was built dynamically, thus it can only be run against OSs where linked objects are potentially in the wrong place.

Describe the solution you've provided

This builds the Linux CLIs using musl libc, which allows the binary to be statically linked, thus allowing the cli to run independent on the host's linked shared objects.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

@hoshsadiq hoshsadiq marked this pull request as ready for review August 19, 2024 12:23
@mike-zorn
Copy link
Contributor

mike-zorn commented Aug 19, 2024

Do you wanna also add a revert of 92aec6e (to change back to alpine base images)?

@hoshsadiq
Copy link
Member Author

Revert ubuntu base build: #408

@cwaldren-ld
Copy link
Contributor

which allows the binary to be dynamically linked,

Is this supposed to say statically linked?

@hoshsadiq hoshsadiq merged commit d30fed0 into main Aug 19, 2024
10 checks passed
@hoshsadiq hoshsadiq deleted the fix/static-builds-musl branch August 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants