feat: Add support for getting the logger from server-side SDKs. #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Nov 13, 2024
| * | ||
| * For all platforms that support logging the logger should be present. | ||
| */ | ||
| get logger(): LDLogger | undefined; |
There was a problem hiding this comment.
Using an accessor here instead of a readonly property which should make this a little more flexible and also less likely to be assigned over in JS.
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
keelerm84
approved these changes
Nov 13, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Nov 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 1.3.2</summary> ## [1.3.2](akamai-edgeworker-sdk-common-v1.3.1...akamai-edgeworker-sdk-common-v1.3.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.9.1 to ^2.10.0 </details> <details><summary>akamai-server-base-sdk: 2.1.20</summary> ## [2.1.20](akamai-server-base-sdk-v2.1.19...akamai-server-base-sdk-v2.1.20) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.3.1 to ^1.3.2 * @launchdarkly/js-server-sdk-common bumped from ^2.9.1 to ^2.10.0 </details> <details><summary>akamai-server-edgekv-sdk: 1.3.0</summary> ## [1.3.0](akamai-server-edgekv-sdk-v1.2.1...akamai-server-edgekv-sdk-v1.3.0) (2024-11-14) ### Features * Upgrade edgekv bundled files to 0.6.3 ([#610](#610)) ([58dfec6](58dfec6)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.3.1 to ^1.3.2 * @launchdarkly/js-server-sdk-common bumped from ^2.9.1 to ^2.10.0 </details> <details><summary>cloudflare-server-sdk: 2.6.2</summary> ## [2.6.2](cloudflare-server-sdk-v2.6.1...cloudflare-server-sdk-v2.6.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.5.1 to 2.5.2 </details> <details><summary>js-server-sdk-common: 2.10.0</summary> ## [2.10.0](js-server-sdk-common-v2.9.1...js-server-sdk-common-v2.10.0) (2024-11-14) ### Features * Add support for getting the logger from server-side SDKs. ([#684](#684)) ([1c411a1](1c411a1)) </details> <details><summary>js-server-sdk-common-edge: 2.5.2</summary> ## [2.5.2](js-server-sdk-common-edge-v2.5.1...js-server-sdk-common-edge-v2.5.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.9.1 to 2.10.0 </details> <details><summary>node-server-sdk: 9.7.2</summary> ## [9.7.2](node-server-sdk-v9.7.1...node-server-sdk-v9.7.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.9.1 to 2.10.0 </details> <details><summary>node-server-sdk-dynamodb: 6.2.2</summary> ## [6.2.2](node-server-sdk-dynamodb-v6.2.1...node-server-sdk-dynamodb-v6.2.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.7.1 to 9.7.2 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.2 </details> <details><summary>node-server-sdk-otel: 1.1.2</summary> ## [1.1.2](node-server-sdk-otel-v1.1.1...node-server-sdk-otel-v1.1.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.7.1 to 9.7.2 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.2 </details> <details><summary>node-server-sdk-redis: 4.2.2</summary> ## [4.2.2](node-server-sdk-redis-v4.2.1...node-server-sdk-redis-v4.2.2) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.7.1 to 9.7.2 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.2 </details> <details><summary>server-sdk-ai: 0.2.1</summary> ## [0.2.1](server-sdk-ai-v0.2.0...server-sdk-ai-v0.2.1) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common bumped from 2.9.0 to 2.10.0 * peerDependencies * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.10.0 </details> <details><summary>vercel-server-sdk: 1.3.21</summary> ## [1.3.21](vercel-server-sdk-v1.3.20...vercel-server-sdk-v1.3.21) (2024-11-14) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.5.1 to 2.5.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.