fix: Do not include _ldMeta in returned config. #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
kinyoklion
commented
Nov 6, 2024
| $metadata: { httpStatusCode: 400 }, | ||
| }; | ||
|
|
||
| // TODO: We may want a track failure. |
There was a problem hiding this comment.
This can be added in another PR once we have an answer.
tanderson-ld
approved these changes
Nov 8, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Nov 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>server-sdk-ai: 0.1.1</summary> ## [0.1.1](server-sdk-ai-v0.1.0...server-sdk-ai-v0.1.1) (2024-11-08) ### Bug Fixes * Do not include _ldMeta in returned config. ([#668](#668)) ([89ce6db](89ce6db)) * Remove underscore token usage. Improve documentation. ([#667](#667)) ([5fe36fb](5fe36fb)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this was to add unit tests, but it ended up with a bug fix, so that is the PR title.