Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Further fix for node types. #648

Closed
wants to merge 1 commit into from
Closed

fix: Further fix for node types. #648

wants to merge 1 commit into from

Conversation

kinyoklion
Copy link
Member

I made a mistake with the types on the last one and this corrects those. It made the node package build, but it caused incompatible cascading types.

@kinyoklion kinyoklion requested a review from a team as a code owner October 31, 2024 19:13
@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 18517 bytes
Size limit: 21000

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15292 bytes
Size limit: 20000

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19278 bytes
Size limit: 21000

@kinyoklion kinyoklion closed this Oct 31, 2024
@kinyoklion kinyoklion deleted the rlamb/typing-change-2 branch October 31, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kinyoklion