chore: Change testing to use cjs. #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 25, 2024
| @@ -1,5 +1,4 @@ | |||
| import { jest } from '@jest/globals'; | |||
There was a problem hiding this comment.
I put the TextEncoder and a crypto fix into a setup script.
kinyoklion
commented
Oct 25, 2024
There was a problem hiding this comment.
Converted to JSON to remove the decision of ESM/CJS.
kinyoklion
commented
Oct 25, 2024
| @@ -30,14 +30,12 @@ | |||
| "build": "tsc --noEmit && rollup -c rollup.config.js", | |||
| "lint": "eslint . --ext .ts,.tsx", | |||
| "prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../.prettierignore", | |||
| "test": "NODE_OPTIONS=--experimental-vm-modules npx jest --runInBand", | |||
| "test": "npx jest --runInBand", | |||
There was a problem hiding this comment.
No longer require experimental options.
One of the many benefits is that I can get the debugger to work for this package now.
kinyoklion
commented
Oct 25, 2024
| @@ -62,6 +60,7 @@ | |||
| "prettier": "^3.0.0", | |||
| "rimraf": "^5.0.5", | |||
| "rollup": "^3.23.0", | |||
| "rollup-plugin-visualizer": "^5.12.0", | |||
There was a problem hiding this comment.
This should have been a dev dependency to begin with.
kinyoklion
commented
Oct 25, 2024
| "coverage": "yarn test --coverage", | ||
| "check": "yarn prettier && yarn lint && yarn build && yarn test" | ||
| }, | ||
| "dependencies": { | ||
| "@launchdarkly/js-client-sdk-common": "1.10.0", | ||
| "escape-string-regexp": "^5.0.0", |
There was a problem hiding this comment.
This package is ESM only, just vendoring it removes that as a factor in the builds.
kinyoklion
commented
Oct 25, 2024
packages/sdk/browser/setup-jest.js
Outdated
|
|
||
| Object.assign(window, { TextDecoder, TextEncoder }); | ||
|
|
||
| Object.defineProperty(global.self, "crypto", { |
There was a problem hiding this comment.
This is to resolve the "digest of undefined" issue.
kinyoklion
force-pushed
the
rlamb/simplify-testing
branch
from
e87f59e
to
55828db
Compare
kinyoklion
force-pushed
the
rlamb/simplify-testing
branch
from
55828db
to
0349691
Compare
tanderson-ld
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: Change browser packages testing to use CJS.
feat: Vendor escapeStringRegexp to simplify builds.
END_COMMIT_OVERRIDE
SDK-816