-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial SDK library boilerplate and basic svelte LD SDK #632
Open
nosnibor89
wants to merge
5
commits into
launchdarkly:main
Choose a base branch
from
nosnibor89:feat/svelte-sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
26f564e
add initial SDK library boilerplate and basic svelte LD SDK
robinson-md 22a3378
Refactor test file paths and update Vite config
robinson-md 147f67b
intial refactor to use new "@launchdarkly/js-client-sdk"
robinson-md 938314c
refactor: update SvelteLDClient tests to use clientSideID
nosnibor89 3bf80cb
Merge pull request #1 from nosnibor89/feat/svelte-sdk-core-js-refactor
nosnibor89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
.DS_Store | ||
node_modules | ||
/build | ||
/dist | ||
/.svelte-kit | ||
/package | ||
.env | ||
.env.* | ||
!.env.example | ||
vite.config.js.timestamp-* | ||
|
||
# Playwright | ||
/test-results |
255 changes: 255 additions & 0 deletions
255
packages/sdk/svelte/__tests__/lib/client/SvelteLDClient.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,255 @@ | ||
import { EventEmitter } from 'node:events'; | ||
import { get } from 'svelte/store'; | ||
import { afterEach, beforeEach, describe, expect, it, Mock, vi } from 'vitest'; | ||
|
||
import { initialize, LDClient } from '@launchdarkly/js-client-sdk'; | ||
|
||
import { LD } from '../../../src/lib/client/SvelteLDClient'; | ||
|
||
vi.mock('@launchdarkly/js-client-sdk', { spy: true }); | ||
|
||
const clientSideID = 'test-client-side-id'; | ||
const rawFlags = { 'test-flag': true, 'another-test-flag': 'flag-value' }; | ||
|
||
// used to mock ready and change events on the LDClient | ||
const mockLDEventEmitter = new EventEmitter(); | ||
|
||
const mockLDClient = { | ||
on: (e: string, cb: () => void) => mockLDEventEmitter.on(e, cb), | ||
off: vi.fn(), | ||
allFlags: vi.fn().mockReturnValue(rawFlags), | ||
variation: vi.fn(), | ||
identify: vi.fn(), | ||
}; | ||
|
||
describe('launchDarkly', () => { | ||
describe('createLD', () => { | ||
it('should create a LaunchDarkly instance with correct properties', () => { | ||
const ld = LD; | ||
expect(typeof ld).toBe('object'); | ||
expect(ld).toHaveProperty('identify'); | ||
expect(ld).toHaveProperty('flags'); | ||
expect(ld).toHaveProperty('initialize'); | ||
expect(ld).toHaveProperty('initializing'); | ||
expect(ld).toHaveProperty('watch'); | ||
expect(ld).toHaveProperty('isOn'); | ||
}); | ||
|
||
describe('initialize', async () => { | ||
const ld = LD; | ||
|
||
beforeEach(() => { | ||
// mocks the initialize function to return the mockLDClient | ||
(initialize as Mock<typeof initialize>).mockReturnValue( | ||
mockLDClient as unknown as LDClient, | ||
); | ||
}); | ||
|
||
afterEach(() => { | ||
vi.clearAllMocks(); | ||
mockLDEventEmitter.removeAllListeners(); | ||
}); | ||
|
||
it('should throw an error if the client is not initialized', async () => { | ||
const flagKey = 'test-flag'; | ||
const user = { key: 'user1' }; | ||
|
||
expect(() => ld.isOn(flagKey)).toThrow('LaunchDarkly client not initialized'); | ||
await expect(() => ld.identify(user)).rejects.toThrow( | ||
'LaunchDarkly client not initialized', | ||
); | ||
}); | ||
|
||
it('should set the loading status to false when the client is ready', async () => { | ||
const { initializing } = ld; | ||
ld.initialize(clientSideID); | ||
|
||
expect(get(initializing)).toBe(true); // should be true before the ready event is emitted | ||
mockLDEventEmitter.emit('ready'); | ||
|
||
expect(get(initializing)).toBe(false); | ||
}); | ||
|
||
it('should initialize the LaunchDarkly SDK instance', () => { | ||
ld.initialize(clientSideID); | ||
|
||
expect(initialize).toHaveBeenCalledWith('test-client-side-id'); | ||
}); | ||
|
||
it('should register function that gets flag values when client is ready', () => { | ||
const newFlags = { ...rawFlags, 'new-flag': true }; | ||
const allFlagsSpy = vi.spyOn(mockLDClient, 'allFlags').mockReturnValue(newFlags); | ||
|
||
ld.initialize(clientSideID); | ||
mockLDEventEmitter.emit('ready'); | ||
|
||
expect(allFlagsSpy).toHaveBeenCalledOnce(); | ||
expect(allFlagsSpy).toHaveReturnedWith(newFlags); | ||
}); | ||
|
||
it('should register function that gets flag values when flags changed', () => { | ||
const changedFlags = { ...rawFlags, 'changed-flag': true }; | ||
const allFlagsSpy = vi.spyOn(mockLDClient, 'allFlags').mockReturnValue(changedFlags); | ||
|
||
ld.initialize(clientSideID); | ||
mockLDEventEmitter.emit('change'); | ||
|
||
expect(allFlagsSpy).toHaveBeenCalledOnce(); | ||
expect(allFlagsSpy).toHaveReturnedWith(changedFlags); | ||
}); | ||
}); | ||
|
||
describe('watch function', () => { | ||
const ld = LD; | ||
|
||
beforeEach(() => { | ||
// mocks the initialize function to return the mockLDClient | ||
(initialize as Mock<typeof initialize>).mockReturnValue( | ||
mockLDClient as unknown as LDClient, | ||
); | ||
}); | ||
|
||
afterEach(() => { | ||
vi.clearAllMocks(); | ||
mockLDEventEmitter.removeAllListeners(); | ||
}); | ||
|
||
it('should return a derived store that reflects the value of the specified flag', () => { | ||
const flagKey = 'test-flag'; | ||
ld.initialize(clientSideID); | ||
|
||
const flagStore = ld.watch(flagKey); | ||
|
||
expect(get(flagStore)).toBe(true); | ||
}); | ||
|
||
it('should update the flag store when the flag value changes', () => { | ||
const booleanFlagKey = 'test-flag'; | ||
const stringFlagKey = 'another-test-flag'; | ||
ld.initialize(clientSideID); | ||
const flagStore = ld.watch(booleanFlagKey); | ||
const flagStore2 = ld.watch(stringFlagKey); | ||
|
||
// 'test-flag' initial value is true according to `rawFlags` | ||
expect(get(flagStore)).toBe(true); | ||
// 'another-test-flag' intial value is 'flag-value' according to `rawFlags` | ||
expect(get(flagStore2)).toBe('flag-value'); | ||
|
||
mockLDClient.allFlags.mockReturnValue({ | ||
...rawFlags, | ||
'test-flag': false, | ||
'another-test-flag': 'new-flag-value', | ||
}); | ||
|
||
// dispatch a change event on ldClient | ||
mockLDEventEmitter.emit('change'); | ||
|
||
expect(get(flagStore)).toBe(false); | ||
expect(get(flagStore2)).toBe('new-flag-value'); | ||
}); | ||
|
||
it('should return undefined if the flag is not found', () => { | ||
const flagKey = 'non-existent-flag'; | ||
ld.initialize(clientSideID); | ||
|
||
const flagStore = ld.watch(flagKey); | ||
|
||
expect(get(flagStore)).toBeUndefined(); | ||
}); | ||
}); | ||
|
||
// TODO: fix these tests | ||
// describe('isOn function', () => { | ||
// const ld = LD; | ||
|
||
// beforeEach(() => { | ||
// // mocks the initialize function to return the mockLDClient | ||
// (initialize as Mock<typeof initialize>).mockReturnValue( | ||
// mockLDClient as unknown as LDClient, | ||
// ); | ||
// }); | ||
|
||
// afterEach(() => { | ||
// vi.clearAllMocks(); | ||
// mockLDEventEmitter.removeAllListeners(); | ||
// }); | ||
|
||
// it('should return true if the flag is on', () => { | ||
// const flagKey = 'test-flag'; | ||
// ld.initialize(clientSideID); | ||
|
||
// expect(ld.isOn(flagKey)).toBe(true); | ||
// }); | ||
|
||
// it('should return false if the flag is off', () => { | ||
// const flagKey = 'test-flag'; | ||
// ld.initialize(clientSideID); | ||
|
||
// mockAllFlags.mockReturnValue({ ...rawFlags, 'test-flag': false }); | ||
|
||
// // dispatch a change event on ldClient | ||
// const changeCallback = mockLDClient.on.mock.calls[0][1]; | ||
// changeCallback(); | ||
|
||
// expect(ld.isOn(flagKey)).toBe(false); | ||
// }); | ||
|
||
// it('should return false if the flag is not found', () => { | ||
// const flagKey = 'non-existent-flag'; | ||
// ld.initialize(clientSideID, { key: 'user1' }); | ||
|
||
// expect(ld.isOn(flagKey)).toBe(false); | ||
// }); | ||
// }); | ||
|
||
// describe('identify function', () => { | ||
// const ld = LD; | ||
// beforeEach(() => { | ||
// mockInitialize.mockImplementation(() => mockLDClient); | ||
// mockAllFlags.mockImplementation(() => rawFlags); | ||
// }); | ||
|
||
// it('should call the identify method on the LaunchDarkly client', () => { | ||
// const user = { key: 'user1' }; | ||
// ld.initialize(clientSideID, user); | ||
|
||
// ld.identify(user); | ||
|
||
// expect(mockLDClient.identify).toHaveBeenCalledWith(user); | ||
// }); | ||
// }); | ||
|
||
// describe('flags store', () => { | ||
// const ld = LD; | ||
// beforeEach(() => { | ||
// mockInitialize.mockImplementation(() => mockLDClient); | ||
// mockAllFlags.mockImplementation(() => rawFlags); | ||
// }); | ||
|
||
// it('should return a readonly store of the flags', () => { | ||
// ld.initialize(clientSideID, { key: 'user1' }); | ||
|
||
// const { flags } = ld; | ||
|
||
// expect(get(flags)).toEqual(rawFlags); | ||
// }); | ||
|
||
// it('should update the flags store when the flags change', () => { | ||
// ld.initialize(clientSideID, { key: 'user1' }); | ||
|
||
// const { flags } = ld; | ||
|
||
// expect(get(flags)).toEqual(rawFlags); | ||
|
||
// const newFlags = { 'test-flag': false, 'another-test-flag': true }; | ||
// mockAllFlags.mockReturnValue(newFlags); | ||
|
||
// // dispatch a change event on ldClient | ||
// const changeCallback = mockLDClient.on.mock.calls[0][1]; | ||
// changeCallback(); | ||
|
||
// expect(get(flags)).toEqual(newFlags); | ||
// }); | ||
// }); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
{ | ||
"name": "@launchdarkly/svelte-client-sdk", | ||
"version": "1.0.0", | ||
"description": "Svelte LaunchDarkly SDK", | ||
"homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/sdk/svelte", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/launchdarkly/js-core.git" | ||
}, | ||
"license": "Apache-2.0", | ||
"packageManager": "[email protected]", | ||
"keywords": [ | ||
"launchdarkly", | ||
"svelte" | ||
], | ||
"type": "module", | ||
"svelte": "./dist/index.js", | ||
"types": "./dist/index.d.ts", | ||
"exports": { | ||
".": { | ||
"types": "./dist/index.d.ts", | ||
"svelte": "./dist/index.js", | ||
"default": "./dist/index.js" | ||
} | ||
}, | ||
"files": [ | ||
"dist", | ||
"!dist/**/*.test.*", | ||
"!dist/**/*.spec.*" | ||
], | ||
"scripts": { | ||
"clean": "rimraf dist", | ||
"dev": "vite dev", | ||
"build": "vite build && npm run package", | ||
"preview": "vite preview", | ||
"package": "svelte-kit sync && svelte-package && publint", | ||
"prepublishOnly": "npm run package", | ||
"lint": "eslint . --ext .ts,.tsx", | ||
"prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../.prettierignore", | ||
"check": "yarn prettier && yarn lint && yarn build && yarn test", | ||
"test": "playwright test", | ||
"test:unit": "vitest", | ||
"test:unit-ui": "vitest --ui" | ||
}, | ||
"peerDependencies": { | ||
"@launchdarkly/js-client-sdk": "workspace:^", | ||
"@launchdarkly/js-client-sdk-common": "^1.10.0", | ||
"@launchdarkly/node-server-sdk": "^9.4.6", | ||
"svelte": "^4.0.0" | ||
}, | ||
"dependencies": { | ||
"@launchdarkly/js-client-sdk": "workspace:^", | ||
"@launchdarkly/js-client-sdk-common": "1.10.0", | ||
"esm-env": "^1.0.0" | ||
}, | ||
"devDependencies": { | ||
"@playwright/test": "^1.28.1", | ||
"@sveltejs/adapter-auto": "^3.0.0", | ||
"@sveltejs/kit": "^2.0.0", | ||
"@sveltejs/package": "^2.0.0", | ||
"@sveltejs/vite-plugin-svelte": "^3.0.0", | ||
"@testing-library/svelte": "^5.2.0", | ||
"@types/jest": "^29.5.11", | ||
"@typescript-eslint/eslint-plugin": "^6.20.0", | ||
"@typescript-eslint/parser": "^6.20.0", | ||
"@vitest/ui": "^1.6.0", | ||
"eslint": "^8.45.0", | ||
"eslint-config-airbnb-base": "^15.0.0", | ||
"eslint-config-airbnb-typescript": "^17.1.0", | ||
"eslint-config-prettier": "^8.8.0", | ||
"eslint-plugin-import": "^2.27.5", | ||
"eslint-plugin-jest": "^27.6.3", | ||
"eslint-plugin-prettier": "^5.0.0", | ||
"eslint-plugin-svelte": "^2.35.1", | ||
"jsdom": "^24.0.0", | ||
"launchdarkly-js-test-helpers": "^2.2.0", | ||
"prettier": "^3.0.0", | ||
"prettier-plugin-svelte": "^3.1.2", | ||
"publint": "^0.1.9", | ||
"rimraf": "^5.0.5", | ||
"svelte": "^4.2.7", | ||
"svelte-check": "^3.6.0", | ||
"ts-jest": "^29.1.1", | ||
"ts-node": "^10.9.2", | ||
"typedoc": "0.25.0", | ||
"typescript": "5.1.6", | ||
"vite": "^5.2.6", | ||
"vitest": "^2.1.4" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import type { PlaywrightTestConfig } from '@playwright/test'; | ||
|
||
const config: PlaywrightTestConfig = { | ||
webServer: { | ||
command: 'npm run build && npm run preview', | ||
port: 4173 | ||
}, | ||
testDir: 'tests', | ||
testMatch: /(.+\.)?(test|spec)\.[jt]s/ | ||
}; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// See https://kit.svelte.dev/docs/types#app | ||
// for information about these interfaces | ||
declare global { | ||
namespace App { | ||
// interface Error {} | ||
// interface Locals {} | ||
// interface PageData {} | ||
// interface PageState {} | ||
// interface Platform {} | ||
} | ||
} | ||
|
||
export {}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like svelte doesn't support CJS? That makes things very pleasant.