Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Scaffold jest mock project. #483

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

yusinto
Copy link
Contributor

@yusinto yusinto commented Jun 18, 2024

As part of the mentorship program, @professorice and I have been working on the react-native mock library. This PR is to scaffold the jest mock library in js-core, so we can work on the react-native mock library and also other jest mocks in the future.

# The new jest package lives here
packages/tooling/jest

@yusinto yusinto requested a review from a team June 18, 2024 18:34
@yusinto yusinto changed the title chore: Scaffold jest mock project chore: Scaffold jest mock project. Jun 18, 2024
@yusinto yusinto enabled auto-merge (squash) June 18, 2024 18:38
@@ -0,0 +1,3 @@
# Changelog

All notable changes to the LaunchDarkly Jest package will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a continuation of the existing library?

Copy link
Contributor Author

@yusinto yusinto Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not. It will be a new library published under @launchdarkly/jest and initially only supports react-native mocks. Subsequently it should only support mocks for new major versions of the react and js sdks under js-core.

@yusinto yusinto requested a review from kinyoklion June 19, 2024 05:37
Comment on lines +324 to +325
# HACK: jest is not ready for release yet.
if: false #${{ needs.release-please.outputs.package-tooling-jest-release == 'true' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinyoklion this should stop auto-release. Manual publish is still active, but I think that's ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent publishing packages, but will still make release PRs with changelog entries and things. Which is fine so long as you are ok with the tags and things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok ta. I've also rolled back release-please-config.json.

@yusinto yusinto merged commit 5775ee7 into main Jun 20, 2024
19 checks passed
@yusinto yusinto deleted the yus/sc-246324/scaffold-jest-mock-project-in-js-core branch June 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants