fixing comments

launchdarkly · Oct 15, 2024 · c22fd0e · c22fd0e
1 parent a16aa37
commit c22fd0e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/packages/sdk/browser/src/BrowserDataManager.ts b/packages/sdk/browser/src/BrowserDataManager.ts
@@ -212,7 +212,7 @@ export default class BrowserDataManager extends BaseDataManager {
     const pollingRequestor = makeRequestor(
       plainContextString,
       this.config.serviceEndpoints,
-      this.getPollingPaths(), // note: this is the polling path because the requestor is only used to make polling requests.
+      this.getPollingPaths(),
       this.platform.requests,
       this.platform.encoding!,
       this.baseHeaders,

diff --git a/packages/sdk/react-native/__tests__/MobileDataManager.test.ts b/packages/sdk/react-native/__tests__/MobileDataManager.test.ts
@@ -133,6 +133,8 @@ describe('given a MobileDataManager with mocked dependencies', () => {
           return `/msdk/evalx/context`;
         },
         pathPing(_encoding: Encoding, _plainContextString: string): string {
+          // Note: if you are seeing this error, it is a coding error. This DataSourcePaths implementation is for polling endpoints. /ping is not currently
+          // used in a polling situation. It is probably the case that this was called by streaming logic erroneously.
           throw new Error('Ping for polling unsupported.');
         },
       }),

diff --git a/packages/sdk/react-native/src/MobileDataManager.ts b/packages/sdk/react-native/src/MobileDataManager.ts
@@ -100,7 +100,7 @@ export default class MobileDataManager extends BaseDataManager {
     const requestor = makeRequestor(
       plainContextString,
       this.config.serviceEndpoints,
-      this.getPollingPaths(), // note: this is the polling path because the requestor is only used to make polling requests.
+      this.getPollingPaths(),
       this.platform.requests,
       this.platform.encoding!,
       this.baseHeaders,

diff --git a/packages/shared/sdk-client/__tests__/TestDataManager.ts b/packages/shared/sdk-client/__tests__/TestDataManager.ts
@@ -79,7 +79,7 @@ export default class TestDataManager extends BaseDataManager {
     const requestor = makeRequestor(
       JSON.stringify(Context.toLDContext(context)),
       this.config.serviceEndpoints,
-      this.getPollingPaths(), // note: this is the polling path because the requestor is only used to make polling requests.
+      this.getPollingPaths(),
       this.platform.requests,
       this.platform.encoding!,
       this.baseHeaders,