Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to automatically create flag links #97

Merged
merged 29 commits into from
Mar 1, 2024
Merged

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Feb 23, 2024

Users will need to use a token with write access

This is what it looks like without a formal flagLinks integration

See created link here: https://app.launchdarkly.com/demo-dan-042021-2/development/features/mobile-app-promo-ios/links

CleanShot 2024-02-23 at 13 47 40

with a github integration

CleanShot 2024-02-23 at 16 44 39

@github-actions github-actions bot added the ld-flags LaunchDarkly flags have been detected in the PR diff label Feb 23, 2024
@jazanne jazanne changed the title Jwhite/flag links allow users to automatically create flag links Feb 23, 2024
@jazanne jazanne marked this pull request as ready for review February 23, 2024 22:01
@jazanne jazanne requested a review from a team February 23, 2024 22:01
@jazanne jazanne requested a review from mmrj February 23, 2024 22:05
README.md Outdated
Comment on lines 10 to 15
This action requires a [LaunchDarkly access token](https://docs.launchdarkly.com/home/account-security/api-access-tokens) with:

1. Read access for the designated `project-key`
2. (Optionally) `createFlagLink` role when `create-flag-links: true`

Access tokens should be stored as an [encrypted secret](https://docs.github.com/en/actions/security-guides/encrypted-secrets).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmrj would love feedback around these access token changes

Copy link

@ctawiah ctawiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very excited to see this come alive. Great work on this 🥇 🙇🏽

Copy link
Contributor

@mmrj mmrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs suggestions. Thanks for putting this together!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@launchdarkly launchdarkly deleted a comment from github-actions bot Mar 1, 2024
@jazanne jazanne merged commit 190a865 into main Mar 1, 2024
5 checks passed
@jazanne jazanne deleted the jwhite/flag-links branch March 1, 2024 16:39
@launchdarkly launchdarkly deleted a comment from github-actions bot Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Show: App Promo mobile-app-promo-ios mobile-app-promo-ios ✅ all references removed
ℹ️ archived on 2023-08-03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ld-flags LaunchDarkly flags have been detected in the PR diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants