[sc-231506] fix: extinction checking not working correctly #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #231506: [pr commenter] falsely saying all refs have been removed. |
LaunchDarkly flag references🔍 1 flag added or modified
❌ 1 flag removed
|
github-actions
bot
added
the
ld-flags
jazanne
commented
Feb 5, 2024
| delimiters := strings.Join(lsearch.GetDelimiters(opts), "") | ||
| elements := make([]lsearch.ElementMatcher, 0, 1) | ||
| elements = append(elements, lsearch.NewElementMatcher(opts.ProjKey, opts.Dir, delimiters, flagKeys, aliasesByFlagKey)) | ||
| matcher = lsearch.Matcher{ | ||
| elements = append(elements, lsearch.NewElementMatcher(opts.ProjKey, "", delimiters, flagKeys, aliasesByFlagKey)) |
There was a problem hiding this comment.
this is the fix - this was setup for monorepo support, but didn't work correctly with scanning.
annabkr
reviewed
Feb 5, 2024
| oldPricingBanner | ||
| show_widgets | ||
| oldPricingBanner | ||
| mobile-app-promo-ios | ||
| mobile-app-promo-ios |
There was a problem hiding this comment.
yea just test data to show that everything is working properly (see comment) - this file changes with most PRs
annabkr
approved these changes
Feb 5, 2024
jazanne
deleted the
jwhite/sc-231506/pr-commenter-falsely-saying-all-refs-have
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't properly checking for flag extinctions, because the project element matcher wasn't configured right.
Also adds new logging helpers and debug logs for github actions debug mode