Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-223627] indicate changed flags that are deprecated #74

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Nov 3, 2023

If a flag has been deprecated (but not archived) show a message.

If a archived/deprecated flag is added or modified we show a warning sign. if it's been removed, we show an info symbol.

CleanShot 2024-03-20 at 12 30 59

Copy link

This pull request has been linked to Shortcut Story #223627: [pr commenter] mark deprecated flags.

@github-actions github-actions bot added the ld-flags LaunchDarkly flags have been detected in the PR diff label Nov 3, 2023
@jazanne jazanne force-pushed the jwhite/sc-223627/pr-commenter-mark-deprecated-flags branch 2 times, most recently from d817c46 to 52a8a78 Compare November 13, 2023 22:04
@github-actions github-actions bot removed the ld-flags LaunchDarkly flags have been detected in the PR diff label Nov 13, 2023
@jazanne jazanne force-pushed the jwhite/sc-223627/pr-commenter-mark-deprecated-flags branch from 52a8a78 to 1ab6250 Compare March 11, 2024 13:24
@jazanne jazanne force-pushed the jwhite/sc-223627/pr-commenter-mark-deprecated-flags branch 2 times, most recently from 60b7399 to c087291 Compare March 20, 2024 16:02
Copy link

github-actions bot commented Mar 20, 2024

LaunchDarkly flag references

🔍 3 flags added or modified

Name Key Aliases found Info
Beta UI beta-ui beta-ui ⚠️ deprecated on 2024-03-20
Show: App Promo mobile-app-promo-ios mobile-app-promo-ios ⚠️ archived on 2024-03-20
Show: Live Tiles show-widgets show-widgets

❌ 1 flag removed

Name Key Aliases found Info
old-pricing-banner old-pricing-banner oldPricingBanner ✅ all references removed
ℹ️ deprecated on 2023-11-03

@github-actions github-actions bot added the ld-flags LaunchDarkly flags have been detected in the PR diff label Mar 20, 2024
@jazanne jazanne changed the title Jwhite/sc 223627/pr commenter mark deprecated flags [sc-223627] indicate changed flags that are deprecated Mar 20, 2024
@jazanne jazanne force-pushed the jwhite/sc-223627/pr-commenter-mark-deprecated-flags branch from ef45f9a to 7328450 Compare March 20, 2024 16:38
@jazanne jazanne marked this pull request as ready for review March 20, 2024 16:46
@jazanne jazanne requested a review from a team March 20, 2024 16:46
@jazanne jazanne force-pushed the jwhite/sc-223627/pr-commenter-mark-deprecated-flags branch from 7328450 to 60035a2 Compare March 25, 2024 15:41
@jazanne jazanne merged commit c5f607b into main Mar 25, 2024
5 checks passed
@jazanne jazanne deleted the jwhite/sc-223627/pr-commenter-mark-deprecated-flags branch March 25, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ld-flags LaunchDarkly flags have been detected in the PR diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant