-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect flag extinctions #73
Conversation
LaunchDarkly flag references🔍 2 flags added or modified
❌ 1 flag removed
|
I think this is great! Although, I'm not sure the skull is very clear. Maybe we need another column that says "all references removed" or something like this. |
confirming that if there are no remaining references then the |
@UPatel12 No, the alias found column is showing that those aliases were found and removed - will tag you in a comment to make it more clear |
@@ -1,11 +1,7 @@ | |||
show-widgets | |||
showWidgets | |||
betaUi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UPatel12 this alias of beta-ui
is what was removed, so we try to let people know
ca0078d
to
ded6217
Compare
I'm leaning toward option 2 (without the check mark) out of the two options. The skull & check mark are a little confusing. I like Kerrie's idea of adding a new column for all references that have been removed. 2 options:
|
we don't scan for all flags in repo so we can't do count I really think a boolean column w/true or false will not be visually compelling enough
Maybe the column is something like "all references removed" and then has a checkmark
I want to make sure we're presenting all the info in a way that's really easy to grasp from a quick scan. |
Proposal for change to 4 columns... LaunchDarkly flag references🔍 2 flags added or modified
❌ 1 flag removed
|
23de271
to
7b1e130
Compare
} | ||
setOutputsForChangedFlags("removed", flagsModified) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad, this was wrong before
For each removed flag, we will check if there are any other references remaining i the code! This will make cleanup much easier
Learn more about extinct flags
Open to see design options
## LaunchDarkly flag references ### ❌ 1 flag removedTable options:
Option 1:
show-widgets
showWidgets
beta-ui
betaUi
,beta_ui
Option 2:
show-widgets
showWidgets
beta-ui
betaUi
,beta_ui
Option 3:
show-widgets
showWidgets
beta-ui
betaUi
,beta_ui
Option 4:
show-widgets
showWidgets
beta-ui
betaUi
,beta_ui