Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sc-209335] feat: only allow one env key in configuration #41

Merged
merged 3 commits into from
Aug 2, 2023
Merged

[sc-209335] feat: only allow one env key in configuration #41

merged 3 commits into from
Aug 2, 2023

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Aug 2, 2023

Now that we don't add env configuration info in the comment, limit to one env key

Other changes

  • don't fetch entire flag config for environment when we only need site link
  • refactor usage of flags/flagKeys

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #209335: update environment-key usage.

@jazanne jazanne requested review from a team August 2, 2023 14:35
@jazanne jazanne marked this pull request as ready for review August 2, 2023 14:36
mmrj
mmrj approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mmrj mmrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ from Docs

@jazanne jazanne merged commit 9abd947 into main Aug 2, 2023
2 checks passed
@jazanne jazanne deleted the jwhite/sc-209335/update-environment-key-usage branch August 2, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ld-kyee ld-kyee ld-kyee approved these changes

@mmrj mmrj mmrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jazanne @mmrj @ld-kyee